Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the startBroadcasting/stopBroadcasting test to use nexttick #116

Closed
yaronyg opened this issue Sep 9, 2015 · 0 comments
Closed

Fix the startBroadcasting/stopBroadcasting test to use nexttick #116

yaronyg opened this issue Sep 9, 2015 · 0 comments
Assignees

Comments

@yaronyg
Copy link
Member

@yaronyg yaronyg commented Sep 9, 2015

We have a test that calls start and stop broadcasting a bunch of times. Right now it is recursive but that is bad in JS because of stack limitations. In practice it doesn't matter since we use such a small number of iterations but it's good hygiene to fix it to use nexttick which won't cause the stack issues.

@yaronyg yaronyg added this to the 0.0 - Bring in the public keys milestone Sep 9, 2015
@yaronyg yaronyg self-assigned this Sep 9, 2015
@yaronyg yaronyg added the ready label Sep 15, 2015
@yaronyg yaronyg removed the ready label Oct 8, 2015
@yaronyg yaronyg removed this from the 0.0.1 - Identity Exchange milestone Oct 13, 2015
@yaronyg yaronyg added the 1 - Backlog label Nov 18, 2015
@yaronyg yaronyg closed this Jan 6, 2016
@yaronyg yaronyg added 4 - Done and removed 1 - Backlog labels Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.