Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Fix the startBroadcasting/stopBroadcasting test to use nexttick #116

Closed
yaronyg opened this issue Sep 9, 2015 · 0 comments
Closed

Fix the startBroadcasting/stopBroadcasting test to use nexttick #116

yaronyg opened this issue Sep 9, 2015 · 0 comments
Assignees

Comments

@yaronyg
Copy link
Member

yaronyg commented Sep 9, 2015

We have a test that calls start and stop broadcasting a bunch of times. Right now it is recursive but that is bad in JS because of stack limitations. In practice it doesn't matter since we use such a small number of iterations but it's good hygiene to fix it to use nexttick which won't cause the stack issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant