Fix the startBroadcasting/stopBroadcasting test to use nexttick #116

Closed
yaronyg opened this Issue Sep 9, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@yaronyg
Member

yaronyg commented Sep 9, 2015

We have a test that calls start and stop broadcasting a bunch of times. Right now it is recursive but that is bad in JS because of stack limitations. In practice it doesn't matter since we use such a small number of iterations but it's good hygiene to fix it to use nexttick which won't cause the stack issues.

@yaronyg yaronyg added this to the 0.0 - Bring in the public keys milestone Sep 9, 2015

@yaronyg yaronyg self-assigned this Sep 9, 2015

@yaronyg yaronyg added the ready label Sep 15, 2015

@yaronyg yaronyg removed the ready label Oct 8, 2015

@yaronyg yaronyg removed this from the 0.0.1 - Identity Exchange milestone Oct 13, 2015

@yaronyg yaronyg added the 1 - Backlog label Nov 18, 2015

@yaronyg yaronyg closed this Jan 6, 2016

@yaronyg yaronyg added 4 - Done and removed 1 - Backlog labels Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment