Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SECURITY - Fixes need to identity exchange #133

Open
yaronyg opened this issue Sep 21, 2015 · 1 comment
Open

SECURITY - Fixes need to identity exchange #133

yaronyg opened this issue Sep 21, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@yaronyg
Copy link
Member

@yaronyg yaronyg commented Sep 21, 2015

We need to re-home it on TLS - This will mean getting rid of wrongPeer errors all together and just using TLS to validate identity.

Request Delay - In order to slow down attacks we need to make sure the smallHashStateMachine will only make cb and rnmine requests at the rate of 1 per second.

Response Delay - In order to slow down certain attacks the largeHashStateMachine needs to only accept cb and rnmine requests at the rate of 1 per second. Also note that the current request handling code is purely synchronous so we don't have to worry about handling multiple requests simultaneously, the delay feature will change that. So be aware.

@yaronyg yaronyg added the Security label Sep 21, 2015
@yaronyg yaronyg added the 1 - Backlog label Nov 18, 2015
@yaronyg yaronyg added 0 - Icebox and removed 1 - Backlog labels Jan 6, 2016
@yaronyg yaronyg added the Icebox label Feb 9, 2016
@yaronyg yaronyg added 2 - Ready and removed 0 - Icebox labels Jul 12, 2016
@yaronyg yaronyg self-assigned this Jul 12, 2016
@yaronyg yaronyg added this to the New Infra milestone Jul 12, 2016
@yaronyg
Copy link
Member Author

@yaronyg yaronyg commented Jul 15, 2016

identityexchange.js - Need to remove reference to ThaliEmitter

@yaronyg yaronyg added 3 - Working and removed 2 - Ready labels Jul 15, 2016
@yaronyg yaronyg added 2 - Ready and removed 3 - Working labels Jul 22, 2016
@yaronyg yaronyg added bug Node and removed 2 - Ready labels Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.