Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to change LargerHashStateMachine to two commands #136

yaronyg opened this issue Sep 23, 2015 · 0 comments

Need to change LargerHashStateMachine to two commands #136

yaronyg opened this issue Sep 23, 2015 · 0 comments


Copy link

@yaronyg yaronyg commented Sep 23, 2015

Right now it has three states commands, start, stop and exchangeIdentity. But in reality there are just two three states that only require two commands.

noIdentityExchange - this command would have us tell anyone who asks that we haven't picked anyone to exchange identities with.

exchangeIdentity - Means we have picked someone and if we have the smaller hash then we will advertise wrongPeer (e.g. anyone who talks to our network endpoint is the wrongPeer because the right peer has a larger hash and therefore we are reaching out to them) and if we have the larger hash then we go to waitForCB.

Calling noIdentityExchange just takes us out of identityExchange and back to advertising that we haven't picked who we want to exchange identities with.

So the current three commands are not necessary. But I don't want to do the surgery right now to simplify them down to two commands. Besides I suspect we will be doing some fairly heavy surgery on the identity exchange infrastructure when we bring in the new notifications (including things like adding TLS and possibly negotiating the first part of the protocol over BLE) so it's better to do it then.

@yaronyg yaronyg added the enhancement label Sep 23, 2015
@yaronyg yaronyg added the 1 - Backlog label Nov 18, 2015
@yaronyg yaronyg added 0 - Icebox and removed 1 - Backlog labels Jan 6, 2016
@yaronyg yaronyg self-assigned this Jul 12, 2016
@yaronyg yaronyg added this to the New Infra milestone Jul 12, 2016
@yaronyg yaronyg added 2 - Ready and removed 0 - Icebox labels Jul 12, 2016
@yaronyg yaronyg added bug Node and removed 2 - Ready labels Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.