Make sure identity exchange tests run on desktop, Android and iOS #158

Open
yaronyg opened this Issue Oct 13, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@yaronyg
Member

yaronyg commented Oct 13, 2015

We never got the tests to run all the way to completion on both platforms. We need to do that.

@yaronyg yaronyg added this to the 0.0.1 - Identity Exchange milestone Oct 13, 2015

@yaronyg yaronyg self-assigned this Oct 13, 2015

@yaronyg yaronyg added the in progress label Oct 13, 2015

@yaronyg

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Oct 13, 2015

Member

Make sure to merge in from customer and then do a PR to master

Member

yaronyg commented Oct 13, 2015

Make sure to merge in from customer and then do a PR to master

@yaronyg

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Oct 16, 2015

Member

I found a bug in line 484 of testIdentityExchangeEndpoint, it doesn't show up in the mock on the desktop because the logic in the mock is obviously not consistent with our actual logic. But I am disabling testIdentityExchangeEndpoint for right now because I need to first get the CI environment going.

Member

yaronyg commented Oct 16, 2015

I found a bug in line 484 of testIdentityExchangeEndpoint, it doesn't show up in the mock on the desktop because the logic in the mock is obviously not consistent with our actual logic. But I am disabling testIdentityExchangeEndpoint for right now because I need to first get the CI environment going.

@yaronyg

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Oct 16, 2015

Member

I disabled testSmallerHashStateMachine because I had removed the protections that keep nock from running on mobile because I was told that the fix for the nock issue was in v0.3.0.7 (something I tested on the desktop and found to be true) and was also told that JXcore-Cordova 0.0.7 had JXcore v0.3.0.7. Apparently not. I filed jxcore/jxcore-cordova#82 to find out what is going on.

Member

yaronyg commented Oct 16, 2015

I disabled testSmallerHashStateMachine because I had removed the protections that keep nock from running on mobile because I was told that the fix for the nock issue was in v0.3.0.7 (something I tested on the desktop and found to be true) and was also told that JXcore-Cordova 0.0.7 had JXcore v0.3.0.7. Apparently not. I filed jxcore/jxcore-cordova#82 to find out what is going on.

@yaronyg yaronyg added ready and removed in progress ready labels Oct 19, 2015

@yaronyg yaronyg added the 1 - Backlog label Nov 18, 2015

@yaronyg yaronyg added 0 - Icebox and removed 1 - Backlog labels Jan 6, 2016

@yaronyg yaronyg added the Icebox label Feb 9, 2016

@yaronyg yaronyg removed their assignment Feb 23, 2016

@yaronyg yaronyg self-assigned this Jul 12, 2016

@yaronyg yaronyg added 2 - Ready and removed 0 - Icebox labels Jul 12, 2016

@yaronyg yaronyg added enhancement and removed 2 - Ready labels Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment