New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.js is a beast, it has to be refactored #265

Open
yaronyg opened this Issue Oct 29, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@yaronyg
Member

yaronyg commented Oct 29, 2015

install.js is a critical piece of code. It is the first thing that anyone using Thali ends up calling and it controls if their initial experience will be good or bad. It is also doing a lot of very complex stuff that will continue to evolve over time. We desperately need it to be less of a hacky mess.

@yaronyg

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Dec 1, 2015

Member

Also see #349 and #350

Member

yaronyg commented Dec 1, 2015

Also see #349 and #350

@yaronyg yaronyg added enhancement and removed 1 - Backlog labels Jan 11, 2016

@yaronyg yaronyg added the Icebox label Feb 9, 2016

@larryonoff

This comment has been minimized.

Show comment
Hide comment
@larryonoff

larryonoff Aug 9, 2016

Contributor

@yaronyg we assume that install process

  1. does very complex stuff that is complex to understand. As result it's complex to support.
  2. linked very tightly with Cordova. So we won't be able to use Thali with other solutions like ReactNative.

So we suggest the following.

  1. Decouple Thali from Cordova.
  2. Update install process so that it can be easily used in Cordova and other similar tools.
  3. Implement Thali Cordova plugin so that it installs native packages, Thali and then runs Thali internal install process. Cordova should be considered as a dependency manager that allows us to add Thali as a plugin.

We agree that this is a big change. So we think that if it's accepted it needs to be done after v1 release.

Contributor

larryonoff commented Aug 9, 2016

@yaronyg we assume that install process

  1. does very complex stuff that is complex to understand. As result it's complex to support.
  2. linked very tightly with Cordova. So we won't be able to use Thali with other solutions like ReactNative.

So we suggest the following.

  1. Decouple Thali from Cordova.
  2. Update install process so that it can be easily used in Cordova and other similar tools.
  3. Implement Thali Cordova plugin so that it installs native packages, Thali and then runs Thali internal install process. Cordova should be considered as a dependency manager that allows us to add Thali as a plugin.

We agree that this is a big change. So we think that if it's accepted it needs to be done after v1 release.

@larryonoff

This comment has been minimized.

Show comment
Hide comment
@larryonoff

larryonoff Aug 26, 2016

Contributor

thali/install/setUpTests.sh error handling needs to be improved.

Contributor

larryonoff commented Aug 26, 2016

thali/install/setUpTests.sh error handling needs to be improved.

@larryonoff larryonoff referenced this issue Sep 7, 2016

Open

Move Thali to Typescript #759

0 of 11 tasks complete
@larryonoff

This comment has been minimized.

Show comment
Hide comment
@larryonoff

larryonoff Sep 9, 2016

Contributor

when installer will be a separate from plugintest/www/jxcore/meta_tests/testInstall.js should be revised.

Contributor

larryonoff commented Sep 9, 2016

when installer will be a separate from plugintest/www/jxcore/meta_tests/testInstall.js should be revised.

@yaronyg yaronyg added enhancement Node and removed 0 - Icebox labels Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment