Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out what to do with socket errors with node-ssdp #477

Open
vjrantal opened this issue Jan 21, 2016 · 0 comments
Open

Figure out what to do with socket errors with node-ssdp #477

vjrantal opened this issue Jan 21, 2016 · 0 comments
Labels

Comments

@vjrantal
Copy link
Member

@vjrantal vjrantal commented Jan 21, 2016

When node-ssdp binds to a socket, it adds an error listener. In that listener, the error is only logged, but there is no public API to bubble up the errors in the socket.

We were speculating that this isn't probably a very common error scenario in real life cases, but this issue is as a reminder to double-check what would be a better way of handling this (compared to how we currently handle it, which is ignoring the potential errors).

@yaronyg yaronyg added bug Node labels Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.