Specify and implement SSDP location validation #490

Open
vjrantal opened this Issue Jan 26, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@vjrantal
Member

vjrantal commented Jan 26, 2016

No description provided.

@yaronyg

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Jan 26, 2016

Member

This bug is to make sure that when we get a location header over SSDP that the header can't point us in a random direction. We need to first off make sure it is not a DNS address since we should only be using SSDP for local discovery. Then we need to make sure it is a properly formed IPV4 or IPV6 address. Then ideally we would check the local subnet mask and make sure that the address is within that range. Although that last check makes me slightly nervous if the WiFi infrastructure is really fancy. The point of all this checking is to make sure that we don't get the kind of amplification attacks we saw with UPnP.

Member

yaronyg commented Jan 26, 2016

This bug is to make sure that when we get a location header over SSDP that the header can't point us in a random direction. We need to first off make sure it is not a DNS address since we should only be using SSDP for local discovery. Then we need to make sure it is a properly formed IPV4 or IPV6 address. Then ideally we would check the local subnet mask and make sure that the address is within that range. Although that last check makes me slightly nervous if the WiFi infrastructure is really fancy. The point of all this checking is to make sure that we don't get the kind of amplification attacks we saw with UPnP.

@yaronyg yaronyg removed this from the New Infra milestone Feb 16, 2016

@yaronyg yaronyg added bug Node and removed 0 - Icebox labels Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment