Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do we rotate Express-PouchDB's logs? #53

Open
yaronyg opened this issue Jul 28, 2015 · 5 comments
Open

How do we rotate Express-PouchDB's logs? #53

yaronyg opened this issue Jul 28, 2015 · 5 comments
Labels
Milestone

Comments

@yaronyg
Copy link
Member

@yaronyg yaronyg commented Jul 28, 2015

Express-PouchDB generates its own logs. We either need to figure out how to redirect the information into our logs or we need to figure out how to make sure the logs don't grow without bounds.

@yaronyg yaronyg added the 1 - Backlog label Nov 18, 2015
@yaronyg
Copy link
Member Author

@yaronyg yaronyg commented Jan 5, 2016

This is a security issue because an attacker could potentially figure out how to cause events that trigger a large number of log entries and so fill up the device.

@yaronyg yaronyg added the Icebox label Feb 9, 2016
@yaronyg yaronyg added this to the V1 milestone Aug 3, 2016
@yaronyg yaronyg added 1 - Backlog and removed 0 - Icebox labels Aug 4, 2016
@janl
Copy link

@janl janl commented Aug 25, 2016

would syslog support be an option?

@garrensmith
Copy link

@garrensmith garrensmith commented Aug 28, 2016

That depends on whether they are only using express-pouchdb on the server or are using in Cordova as well. I don't think you can use syslog with Cordova.

@yaronyg
Copy link
Member Author

@yaronyg yaronyg commented Aug 29, 2016

Remember we are recording these logs locally on an Android or iOS device. So I doubt we'll have a syslog deamon. We probably just want some kind of simple file format (we are using Winston at the moment) and we need to make sure we rotate those logs so they don't fill up the device.

@janl
Copy link

@janl janl commented Aug 30, 2016

Gotcha, thanks!

@yaronyg yaronyg added bug Node and removed 1 - Backlog labels Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.