Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On iOS networkChanged events don't accurately reflect the right state #536

Closed
vjrantal opened this issue Feb 12, 2016 · 3 comments
Closed

On iOS networkChanged events don't accurately reflect the right state #536

vjrantal opened this issue Feb 12, 2016 · 3 comments
Assignees
Milestone

Comments

@vjrantal
Copy link
Member

@vjrantal vjrantal commented Feb 12, 2016

In vNext branch, the networkChanged events should be fired if Wifi or Bluetooth HW gets enabled or disabled. Based on manual testing, the event isn't fired according to what one would expect when toggling Wifi or Bluetooth using the iOS "Control Center" (the menu that can be swiped from the bottom of the screen).

@vjrantal vjrantal added this to the New Infra milestone Feb 12, 2016
@yaronyg yaronyg added estimate - 2 and removed 1 - Backlog labels Feb 12, 2016
@vjrantal
Copy link
Member Author

@vjrantal vjrantal commented Feb 16, 2016

@tobybrad: Here is a clip from the specification at thaliMobileNativeWrapper.js that I'd need to be able to test on iOS devices (see the MUST statement):

/**
 * Provides a notification when the network's state changes as well as when our
 * use of the network changes, specifically when discovery or
 * advertising/listening starts and stops. This event MUST fire with the current
 * network state when the first subscription to the event is received.
 *
 * @public
 * @event networkChangedNonTCP
 * @type {Object}
 * @property {module:thaliMobileNative~networkChanged} networkChangedValue
 */
@yaronyg yaronyg closed this Feb 17, 2016
@yaronyg yaronyg added 4 - Done and removed 3 - Working labels Feb 17, 2016
@vjrantal
Copy link
Member Author

@vjrantal vjrantal commented Feb 17, 2016

@tobybrad mentioned in Slack that the issue in the description was not yet fixed, but only the referred MUST part from the specification so reopening this.

@vjrantal vjrantal reopened this Feb 17, 2016
@vjrantal vjrantal added 2 - Ready and removed 4 - Done labels Feb 17, 2016
@yaronyg yaronyg added 1 - Backlog and removed 2 - Ready labels Apr 6, 2016
@yaronyg
Copy link
Member

@yaronyg yaronyg commented Aug 3, 2016

@baydet I'm assigning this to you to make sure we don't repeat this error in the new code.

@yaronyg yaronyg closed this Aug 26, 2016
@yaronyg yaronyg removed the 1 - Backlog label Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.