Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

On iOS networkChanged events don't accurately reflect the right state #536

Closed
vjrantal opened this issue Feb 12, 2016 · 3 comments
Closed
Assignees
Milestone

Comments

@vjrantal
Copy link
Member

vjrantal commented Feb 12, 2016

In vNext branch, the networkChanged events should be fired if Wifi or Bluetooth HW gets enabled or disabled. Based on manual testing, the event isn't fired according to what one would expect when toggling Wifi or Bluetooth using the iOS "Control Center" (the menu that can be swiped from the bottom of the screen).

@vjrantal
Copy link
Member Author

vjrantal commented Feb 16, 2016

@tobybrad: Here is a clip from the specification at thaliMobileNativeWrapper.js that I'd need to be able to test on iOS devices (see the MUST statement):

/**
 * Provides a notification when the network's state changes as well as when our
 * use of the network changes, specifically when discovery or
 * advertising/listening starts and stops. This event MUST fire with the current
 * network state when the first subscription to the event is received.
 *
 * @public
 * @event networkChangedNonTCP
 * @type {Object}
 * @property {module:thaliMobileNative~networkChanged} networkChangedValue
 */

@vjrantal
Copy link
Member Author

vjrantal commented Feb 17, 2016

@tobybrad mentioned in Slack that the issue in the description was not yet fixed, but only the referred MUST part from the specification so reopening this.

@yaronyg
Copy link
Member

yaronyg commented Aug 3, 2016

@baydet I'm assigning this to you to make sure we don't repeat this error in the new code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants