New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement connection failure -based heuristics for peer unavailability in thaliMobile #582

Open
vjrantal opened this Issue Feb 26, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@vjrantal
Member

vjrantal commented Feb 26, 2016

The specification in thaliMobile contains parts like:

 * If an attempt to connect to a peer via MPCF whose presence we have previously
 * advertised via peerAvailabilityChanged should fail we MUST use our own
 * heuristics to decide if we should mark the peer as no longer available.
 * Typically we should allow several failed connection attempts before we decide
 * to mark the peer as no longer present.

Current implementation will mark peers unavailable after certain threshold, but not based on failed connection attempts.

It should be determined how often connection failure -based unavailability would be needed in real life scenarios.

@vjrantal vjrantal referenced this issue Feb 26, 2016

Closed

Implement thaliMobile #359

4 of 4 tasks complete
@yaronyg

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Feb 26, 2016

Member

I think it's fine to skip this entirely for now. E.g. we can just not implement for NewInfra. As it is thaliMobileNativeWrapper will send up a new peerAvailabilityChanged event when this occurs and that will automatically reset our timers. If we try to connect and thaliMobileNative can't make the connect work then we should get a peerAvailabilityChanged from thaliMobileNativeWrapper telling us the peer is gone.

Member

yaronyg commented Feb 26, 2016

I think it's fine to skip this entirely for now. E.g. we can just not implement for NewInfra. As it is thaliMobileNativeWrapper will send up a new peerAvailabilityChanged event when this occurs and that will automatically reset our timers. If we try to connect and thaliMobileNative can't make the connect work then we should get a peerAvailabilityChanged from thaliMobileNativeWrapper telling us the peer is gone.

@yaronyg yaronyg added this to the V1 milestone Aug 3, 2016

@yaronyg yaronyg added bug Node and removed 1 - Backlog labels Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment