Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

Implement connection failure -based heuristics for peer unavailability in thaliMobile #582

Open
vjrantal opened this issue Feb 26, 2016 · 1 comment
Milestone

Comments

@vjrantal
Copy link
Member

vjrantal commented Feb 26, 2016

The specification in thaliMobile contains parts like:

 * If an attempt to connect to a peer via MPCF whose presence we have previously
 * advertised via peerAvailabilityChanged should fail we MUST use our own
 * heuristics to decide if we should mark the peer as no longer available.
 * Typically we should allow several failed connection attempts before we decide
 * to mark the peer as no longer present.

Current implementation will mark peers unavailable after certain threshold, but not based on failed connection attempts.

It should be determined how often connection failure -based unavailability would be needed in real life scenarios.

@vjrantal vjrantal mentioned this issue Feb 26, 2016
4 tasks
@yaronyg
Copy link
Member

yaronyg commented Feb 26, 2016

I think it's fine to skip this entirely for now. E.g. we can just not implement for NewInfra. As it is thaliMobileNativeWrapper will send up a new peerAvailabilityChanged event when this occurs and that will automatically reset our timers. If we try to connect and thaliMobileNative can't make the connect work then we should get a peerAvailabilityChanged from thaliMobileNativeWrapper telling us the peer is gone.

@yaronyg yaronyg added this to the V1 milestone Aug 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants