Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Move us officially over to Next Generation #621
For boring historical reasons (which honestly weren't terribly compelling) we have our old december code co-existing with our vNext code. Once #811 passes and before we check in #740 we need to make this change (hopefully along with @artemjackson's work on #759).
Please make sure to use 'git mv' when moving or renaming things. And yes as you move stuff around all the paths have to be fixed up. I'd suggest using an IDE like WebStorm or IntelliJ that can figure a lot of this out for you automatically so you don't have to chase everything down.
My other suggestion is that we will do #759 once this bug is done. Which again won't happen until #811 is checked in to vNext and you have finished #507 and we have merged #507 and #811 into vNext_yarong_417_1 (e.g. #740).
Although I wonder how much easier this might be if we did #759 first? But I suspect we would have to do a lot of surgery on a lot of files before we saw any benefit and we don't have time for that right now. But talk to @artemjackson about it.
I made an exception for:
We are still using
All files are used in bv_tests.
Yes, this test was just a bit outdated. I've fixed it. We can run it with
We can implement good tests for
I think this can be saved. It was used instead of
I don't think we should delete