Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
There is a bug we ran into on Android where on some devices if we try to publish service data via BLE we will get a 'too long' error even though we have checked what we set 10 ways from Sunday and it appear to meet the length requirements and the identical code works fine on other devices. @tompaana came up with a work around which is that if a device gives him an error when setting service data then instead he will publish using manufacturer's data. Service data advertises a service while manufacturer's data advertises the existence of a piece of hardware.
The only potential problem with this approach is that now everyone has to scan for Thali clients using both service and manufacturer data. What we aren't clear on is - what are the battery implications? Do the phones do any kind of hardware hand off of the scanning for either or both of these?