Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Fix wifiBasedNativedMock for iOS #652

Closed
4 tasks done
yaronyg opened this issue Mar 21, 2016 · 4 comments
Closed
4 tasks done

Fix wifiBasedNativedMock for iOS #652

yaronyg opened this issue Mar 21, 2016 · 4 comments
Assignees
Milestone

Comments

@yaronyg
Copy link
Member

yaronyg commented Mar 21, 2016

The current mock doesn't appear to follow the rules for the mobile layer. So this bug is to collect all the problems and fix them.

  • Change your emergency console.logs to logger.debug so they show up in the coordinator and then figure out how to kill unnecessary connectPeers once the test has passed so we can exit.
  • Implement a test that we don't see peerAvailabilityChanged events until one of the start methods is called (this will require the use of the coordinator)
  • Finish going through the thaliMobileNativeWrapper and thaliMobileNative specs to make sure that we are following the requirements in the mock and that we test those requirements
  • Teach the mock to speak iOS
@yaronyg yaronyg self-assigned this Mar 21, 2016
@yaronyg yaronyg added this to the New Infra milestone Mar 21, 2016
@yaronyg yaronyg changed the title Fix wifiBasedNativedMock Fix wifiBasedNativedMock for iOS Apr 1, 2016
@yaronyg yaronyg removed their assignment Jul 15, 2016
@yaronyg yaronyg added the iOS label Sep 1, 2016
@yaronyg yaronyg added bug Node and removed iOS labels Sep 26, 2016
@yaronyg
Copy link
Member Author

yaronyg commented Sep 26, 2016

@chapko I believe this bug is now effectively a dupe of #903 and we should close it in favor of #903. But can you please check the work items and if you agree then please close this bug?

@yaronyg
Copy link
Member Author

yaronyg commented Oct 3, 2016

@chapko?!?!?!? Can you please respond to the previous question.

@chapko
Copy link
Contributor

chapko commented Oct 4, 2016

@yaronyg yes, my bad. I didn't have time to investigate enough the mock to answer this question. But #903 is obviously a duplicate of the last todo item. I can't say anything about other items

@chapko chapko assigned yaronyg and unassigned chapko Oct 4, 2016
@yaronyg
Copy link
Member Author

yaronyg commented Oct 7, 2016

This has been superseded by #903

@yaronyg yaronyg closed this as completed Oct 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants