Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wifiBasedNativedMock for iOS #652

Closed
yaronyg opened this issue Mar 21, 2016 · 4 comments
Closed

Fix wifiBasedNativedMock for iOS #652

yaronyg opened this issue Mar 21, 2016 · 4 comments
Assignees
Labels
Milestone

Comments

@yaronyg
Copy link
Member

@yaronyg yaronyg commented Mar 21, 2016

The current mock doesn't appear to follow the rules for the mobile layer. So this bug is to collect all the problems and fix them.

  • Change your emergency console.logs to logger.debug so they show up in the coordinator and then figure out how to kill unnecessary connectPeers once the test has passed so we can exit.
  • Implement a test that we don't see peerAvailabilityChanged events until one of the start methods is called (this will require the use of the coordinator)
  • Finish going through the thaliMobileNativeWrapper and thaliMobileNative specs to make sure that we are following the requirements in the mock and that we test those requirements
  • Teach the mock to speak iOS
@yaronyg yaronyg self-assigned this Mar 21, 2016
@yaronyg yaronyg added this to the New Infra milestone Mar 21, 2016
@yaronyg yaronyg added 0 - Icebox and removed 0 - Icebox labels Mar 21, 2016
@yaronyg yaronyg added 1 - Backlog and removed 3 - Working labels Mar 31, 2016
@yaronyg yaronyg changed the title Fix wifiBasedNativedMock Fix wifiBasedNativedMock for iOS Apr 1, 2016
@yaronyg yaronyg removed their assignment Jul 15, 2016
@yaronyg yaronyg added the estimate - 5 label Aug 8, 2016
@yaronyg yaronyg added the iOS label Sep 1, 2016
@yaronyg yaronyg added bug Node and removed iOS labels Sep 26, 2016
@yaronyg
Copy link
Member Author

@yaronyg yaronyg commented Sep 26, 2016

@chapko I believe this bug is now effectively a dupe of #903 and we should close it in favor of #903. But can you please check the work items and if you agree then please close this bug?

@yaronyg
Copy link
Member Author

@yaronyg yaronyg commented Oct 3, 2016

@chapko?!?!?!? Can you please respond to the previous question.

@chapko
Copy link
Contributor

@chapko chapko commented Oct 4, 2016

@yaronyg yes, my bad. I didn't have time to investigate enough the mock to answer this question. But #903 is obviously a duplicate of the last todo item. I can't say anything about other items

@chapko chapko assigned yaronyg and unassigned chapko Oct 4, 2016
@yaronyg
Copy link
Member Author

@yaronyg yaronyg commented Oct 7, 2016

This has been superseded by #903

@yaronyg yaronyg closed this Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.