A careless bug can crash JXcore when using PSK

[yaronyg]

The Crash
Bad Code

I did a bad refactoring where the pskIdToSecret callback (which is eventually used as part of a psk Callback) had some unbounded variables inside of it (e.g. variables that weren't defined anywhere) and that caused JXcore to crash.

[cicorias]

Where are you calling tls.creatserver. Help if you have a line #

[cicorias]

Where are you calling tls.creatserver. Help if you have a line #

[yaronyg]

The function causing the crash is here. The problem was that I had screwed up a refactor and pskIdentity and pskKey were not bound to anything. in other words there was no declaration of either variable in any visible scope. Once I fixed that everything was fine. The createserver is called here

Another crash, I'm investigating now.

[yaronyg]

The function causing the crash is here. The problem was that I had screwed up a refactor and pskIdentity and pskKey were not bound to anything. in other words there was no declaration of either variable in any visible scope. Once I fixed that everything was fine. The createserver is called here

Another crash, I'm investigating now.

[yaronyg]

The new crash btw is in different code. I'll share the code once I figure out what is going on.

[yaronyg]

The new crash btw is in different code. I'll share the code once I figure out what is going on.

[yaronyg]

O.k. this crash was very similar to the first one. Another programming error from yours truly. IN this case the callback function was:

function (id) {
          return self.pskIdToSecret(id);
}

Where self.pskIdToSecret is undefined. That causes an immediate crash with full stack trace.

BTW, I don't consider this bug to be high priority. That's why it's in IceBox.

[yaronyg]

O.k. this crash was very similar to the first one. Another programming error from yours truly. IN this case the callback function was:

function (id) {
          return self.pskIdToSecret(id);
}

Where self.pskIdToSecret is undefined. That causes an immediate crash with full stack trace.

BTW, I don't consider this bug to be high priority. That's why it's in IceBox.

[cicorias]

Ok. I'll just poke around in other native areas and see how they validate undefined callbacks or undefined values

[cicorias]

Ok. I'll just poke around in other native areas and see how they validate undefined callbacks or undefined values