(iOS) please connect == false followed by please connect == true will cause connection faliure #699

Closed
yaronyg opened this Issue Apr 1, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@yaronyg
Member

yaronyg commented Apr 1, 2016

Right now if thaliMobileNativeWrapper gets a peerAvailabilityChanged event from the native layer with available === true and pleaseConnect === false then it will call createPeerListener and create a listener.

If we then get another peerAvailabilityChanged event with available === true but now pleaseConnect === true (e.g. the other party wants to connect to us but per the iOS protocol needs us to initiate) then we will just return the port for the existing listener and do absolutely nothing, we won't actually initiate the connection.

@yaronyg yaronyg self-assigned this Apr 1, 2016

@yaronyg yaronyg added this to the New Infra milestone Apr 1, 2016

@yaronyg yaronyg added bug 0 - Icebox and removed 0 - Icebox labels Apr 1, 2016

@yaronyg yaronyg removed their assignment Jul 15, 2016

@yaronyg

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Aug 3, 2016

Member

We are re-writing this code so this issue doesn't apply.

Member

yaronyg commented Aug 3, 2016

We are re-writing this code so this issue doesn't apply.

@yaronyg yaronyg closed this Aug 3, 2016

@yaronyg yaronyg added 4 - Done and removed 1 - Backlog labels Aug 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment