Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(iOS) please connect == false followed by please connect == true will cause connection faliure #699

Closed
yaronyg opened this issue Apr 1, 2016 · 1 comment
Labels
bug
Milestone

Comments

@yaronyg
Copy link
Member

@yaronyg yaronyg commented Apr 1, 2016

Right now if thaliMobileNativeWrapper gets a peerAvailabilityChanged event from the native layer with available === true and pleaseConnect === false then it will call createPeerListener and create a listener.

If we then get another peerAvailabilityChanged event with available === true but now pleaseConnect === true (e.g. the other party wants to connect to us but per the iOS protocol needs us to initiate) then we will just return the port for the existing listener and do absolutely nothing, we won't actually initiate the connection.

@yaronyg yaronyg self-assigned this Apr 1, 2016
@yaronyg yaronyg added this to the New Infra milestone Apr 1, 2016
@yaronyg yaronyg added bug 0 - Icebox and removed 0 - Icebox labels Apr 1, 2016
@yaronyg yaronyg removed their assignment Jul 15, 2016
@yaronyg
Copy link
Member Author

@yaronyg yaronyg commented Aug 3, 2016

We are re-writing this code so this issue doesn't apply.

@yaronyg yaronyg closed this Aug 3, 2016
@yaronyg yaronyg added 4 - Done and removed 1 - Backlog labels Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.