Skip to content
This repository has been archived by the owner. It is now read-only.

(iOS) please connect == false followed by please connect == true will cause connection faliure #699

Closed
yaronyg opened this issue Apr 1, 2016 · 1 comment
Labels
Milestone

Comments

@yaronyg
Copy link
Member

yaronyg commented Apr 1, 2016

Right now if thaliMobileNativeWrapper gets a peerAvailabilityChanged event from the native layer with available === true and pleaseConnect === false then it will call createPeerListener and create a listener.

If we then get another peerAvailabilityChanged event with available === true but now pleaseConnect === true (e.g. the other party wants to connect to us but per the iOS protocol needs us to initiate) then we will just return the port for the existing listener and do absolutely nothing, we won't actually initiate the connection.

@yaronyg
Copy link
Member Author

yaronyg commented Aug 3, 2016

We are re-writing this code so this issue doesn't apply.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant