Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPM download and version variables to be shared #709

Open
yaronyg opened this issue Apr 20, 2016 · 0 comments
Open

Fix NPM download and version variables to be shared #709

yaronyg opened this issue Apr 20, 2016 · 0 comments
Labels
Milestone

Comments

@yaronyg
Copy link
Member

@yaronyg yaronyg commented Apr 20, 2016

Background: In order to run properly we need to download a custom version of NPM for JXcore. We download this custom version by setting the NPM environment variable NVM_NODEJS_ORG_MIRROR. We also need to set a custom version of NPM. We set that by setting the JXcore environment variable JX_NPM_JXB.

Problem: Right now we set these two environment variables in two different places. One place is appveyor.yml and the other is setUpDesktop.sh. I suspect we also will need to eventually set this up somehow in CI via build.sh but we'll see. In any case, we shouldn't be splattering these values all over the place. Instead they should be set centrally and then picked up by the various scripts that need them.

@yaronyg yaronyg added the 0 - Icebox label Apr 20, 2016
@yaronyg yaronyg added this to the V1 milestone Aug 3, 2016
@yaronyg yaronyg added 1 - Backlog and removed 0 - Icebox labels Aug 4, 2016
@yaronyg yaronyg added enhancement Node and removed 1 - Backlog labels Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.