Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix NPM download and version variables to be shared #709
Background: In order to run properly we need to download a custom version of NPM for JXcore. We download this custom version by setting the NPM environment variable NVM_NODEJS_ORG_MIRROR. We also need to set a custom version of NPM. We set that by setting the JXcore environment variable JX_NPM_JXB.
Problem: Right now we set these two environment variables in two different places. One place is appveyor.yml and the other is setUpDesktop.sh. I suspect we also will need to eventually set this up somehow in CI via build.sh but we'll see. In any case, we shouldn't be splattering these values all over the place. Instead they should be set centrally and then picked up by the various scripts that need them.