Test case, After #startListeningForAdvertisements call wifiPeerAvailabilityChanged events should be emitted, fails randomly on Android

[tompaana]

This test does not seem to do any native calls.

Logcat log below:

04-27 05:29:52.274  3369  3455 I jxcore-log: # teardown
04-27 05:29:52.274  3369  3455 I jxcore-log: 
04-27 05:29:52.294  3369  3455 I jxcore-log: # setup
04-27 05:29:52.294  3369  3455 I jxcore-log: 
04-27 05:29:52.313  3369  3455 I jxcore-log: ok 610 should be in started state
04-27 05:29:52.313  3369  3455 I jxcore-log: 
04-27 05:29:52.316  3369  3455 I jxcore-log: # 162. After #startListeningForAdvertisements call wifiPeerAvailabilityChanged events should be emitted
04-27 05:29:52.316  3369  3455 I jxcore-log: 
04-27 05:29:52.365  3369  3455 I jxcore-log: ok 611 peer identifier should match
04-27 05:29:52.365  3369  3455 I jxcore-log: 
04-27 05:29:52.366  3369  3455 I jxcore-log: ok 612 host address should match
04-27 05:29:52.366  3369  3455 I jxcore-log: 
04-27 05:29:52.366  3369  3455 I jxcore-log: ok 613 port should match
04-27 05:29:52.366  3369  3455 I jxcore-log: 
04-27 05:29:52.375  3369  3455 I jxcore-log: not ok 614 host address should be null
04-27 05:29:52.375  3369  3455 I jxcore-log: 
04-27 05:29:52.375  3369  3455 I jxcore-log:   ---
04-27 05:29:52.375  3369  3455 I jxcore-log: 
04-27 05:29:52.375  3369  3455 I jxcore-log:     operator: equal
04-27 05:29:52.375  3369  3455 I jxcore-log: 
04-27 05:29:52.375  3369  3455 I jxcore-log:     expected: null
04-27 05:29:52.375  3369  3455 I jxcore-log: 
04-27 05:29:52.375  3369  3455 I jxcore-log:     actual:   '4502e468'
04-27 05:29:52.375  3369  3455 I jxcore-log: 
04-27 05:29:52.375  3369  3455 I jxcore-log:   ...
04-27 05:29:52.375  3369  3455 I jxcore-log: 
04-27 05:29:52.379  3369  3455 I jxcore-log: not ok 615 port should should be null
04-27 05:29:52.379  3369  3455 I jxcore-log: 
04-27 05:29:52.379  3369  3455 I jxcore-log:   ---
04-27 05:29:52.379  3369  3455 I jxcore-log: 
04-27 05:29:52.379  3369  3455 I jxcore-log:     operator: equal
04-27 05:29:52.379  3369  3455 I jxcore-log: 
04-27 05:29:52.379  3369  3455 I jxcore-log:     expected: null
04-27 05:29:52.379  3369  3455 I jxcore-log: 
04-27 05:29:52.379  3369  3455 I jxcore-log:     actual:   8080
04-27 05:29:52.379  3369  3455 I jxcore-log: 
04-27 05:29:52.379  3369  3455 I jxcore-log:   ...
04-27 05:29:52.379  3369  3455 I jxcore-log: 
04-27 05:29:52.381  3369  3455 I jxcore-log: # teardown
04-27 05:29:52.381  3369  3455 I jxcore-log: 
04-27 05:29:52.414  3369  3455 I jxcore-log: ok 616 should not be in started state
04-27 05:29:52.414  3369  3455 I jxcore-log: 
04-27 05:29:52.418  3369  3455 I jxcore-log: # setup
04-27 05:29:52.418  3369  3455 I jxcore-log: 
04-27 05:29:52.439  3369  3455 I jxcore-log: ok 617 should be in started state
04-27 05:29:52.439  3369  3455 I jxcore-log: 

[vjrantal]

I looked at the sources of the test and this might be a race condition where the test fails if there is an SSDP alive message on an exact moment. A diff something like this might help:

$ git diff
diff --git a/test/www/jxcore/bv_tests/testThaliWifiInfrastructure.js b/test/www/jxcore/bv_tests/testThaliWifiInfrastructure.js
index 91bb9af..4ec3303 100644
--- a/test/www/jxcore/bv_tests/testThaliWifiInfrastructure.js
+++ b/test/www/jxcore/bv_tests/testThaliWifiInfrastructure.js
@@ -79,7 +79,8 @@ test('After #startListeningForAdvertisements call ' +
       peerAvailableListener);

     var peerUnavailableListener = function (peer) {
-      if (peer.peerIdentifier !== peerIdentifier) {
+      if (peer.peerIdentifier !== peerIdentifier ||
+          peer.hostAddress !== null) {
         return;
       }
       t.equal(peer.hostAddress, null, 'host address should be null');

Even with above change, the test would be meaningful since it would fail unless a peer unavailable message comes after the test server is stopped.

[vjrantal]

I looked at the sources of the test and this might be a race condition where the test fails if there is an SSDP alive message on an exact moment. A diff something like this might help:

$ git diff
diff --git a/test/www/jxcore/bv_tests/testThaliWifiInfrastructure.js b/test/www/jxcore/bv_tests/testThaliWifiInfrastructure.js
index 91bb9af..4ec3303 100644
--- a/test/www/jxcore/bv_tests/testThaliWifiInfrastructure.js
+++ b/test/www/jxcore/bv_tests/testThaliWifiInfrastructure.js
@@ -79,7 +79,8 @@ test('After #startListeningForAdvertisements call ' +
       peerAvailableListener);

     var peerUnavailableListener = function (peer) {
-      if (peer.peerIdentifier !== peerIdentifier) {
+      if (peer.peerIdentifier !== peerIdentifier ||
+          peer.hostAddress !== null) {
         return;
       }
       t.equal(peer.hostAddress, null, 'host address should be null');

Even with above change, the test would be meaningful since it would fail unless a peer unavailable message comes after the test server is stopped.

[yaronyg]

Do we even known if this is still failing?

[yaronyg]

Do we even known if this is still failing?

[artemjackson]

@yaronyg I didn't face with this

[artemjackson]

@yaronyg I didn't face with this