Skip to content
This repository has been archived by the owner. It is now read-only.

We need to add greenkeeper support #731

Open
yaronyg opened this issue Jun 3, 2016 · 2 comments
Open

We need to add greenkeeper support #731

yaronyg opened this issue Jun 3, 2016 · 2 comments

Comments

@yaronyg
Copy link
Member

yaronyg commented Jun 3, 2016

I'm marking this as a bug because it will break us if we don't do this.
I'm marking this as a security issue because it will keep us from getting security updates if we don't do this.

In order to deal with version conflicts that the semver rules in package.json allowed when using ^ or ~ I have had to switch our package.jsons to hard coding a specific version. This then means that we don't get updates, bug fixes, security fixes, etc. This is where Greenkeeper comes in. It will automatically submit PRs and run our tests whenever a dependency gets updated. We need this, badly!

Keep in mind that we actually have four different package.json files in our project and we need them all monitored.

@artemjackson
Copy link
Contributor

artemjackson commented Aug 11, 2016

@yaronyg we cannot use Greenkeeper with Thali_CordovaPlugin because of the current project structure. The project has multiple package.json files when Greenkeeper only supports single package.json and this package.json must be in the repo root.

Please see the solutions we assume:

  • Wait while Greenkeeper team releases multiple package.json support. But this issue doesn't have high priority. See the issue.
  • Implement multiple package.json support for Greenkeeper.
  • Split Thali_CordovaPlugin project into separate projects e.g. thali, thali cordova plugin, tests application. As result each project will have single package.json file.
  • Investigate other tools like Greenkeeper.

@artemjackson artemjackson assigned yaronyg and unassigned artemjackson Aug 11, 2016
@yaronyg yaronyg added P2 and removed P1 labels Aug 11, 2016
@yaronyg yaronyg removed their assignment Aug 12, 2016
@yaronyg yaronyg added Node and removed 1 - Backlog labels Oct 6, 2016
@yaronyg
Copy link
Member Author

yaronyg commented Oct 17, 2016

https://github.com/boennemann/alle#readme

The above explains how PouchDB did it. Not all of it applies to us though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants