Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Add peer removal notice to notifications #733

Open
yaronyg opened this issue Jun 7, 2016 · 1 comment
Open

Add peer removal notice to notifications #733

yaronyg opened this issue Jun 7, 2016 · 1 comment
Assignees
Milestone

Comments

@yaronyg
Copy link
Member

yaronyg commented Jun 7, 2016

Turns out that we never actually implemented an event from thaliNotificationClient to notify folks upstream when a peer has disappeared. Which is rather annoying. So now we need to implement that and put in tests for it.

@yaronyg yaronyg added this to the New Infra milestone Jun 7, 2016
@yaronyg yaronyg self-assigned this Jun 7, 2016
@yaronyg yaronyg removed this from the New Infra milestone Jun 20, 2016
@yaronyg yaronyg removed their assignment Jun 20, 2016
@yaronyg yaronyg added the bug label Jun 20, 2016
@yaronyg yaronyg added this to the V1 milestone Aug 3, 2016
@yaronyg yaronyg added Node and removed P1 labels Sep 26, 2016
@yaronyg
Copy link
Member Author

yaronyg commented Oct 18, 2016

It would certainly seem useful to return this data but I'm not 100% sure if it really matters at this point.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants