Add peer removal notice to notifications #733

Open
yaronyg opened this Issue Jun 7, 2016 · 1 comment

Comments

Projects
None yet
4 participants
@yaronyg
Member

yaronyg commented Jun 7, 2016

Turns out that we never actually implemented an event from thaliNotificationClient to notify folks upstream when a peer has disappeared. Which is rather annoying. So now we need to implement that and put in tests for it.

@yaronyg yaronyg added this to the New Infra milestone Jun 7, 2016

@yaronyg yaronyg self-assigned this Jun 7, 2016

@yaronyg yaronyg added 0 - Icebox and removed 0 - Icebox labels Jun 7, 2016

@yaronyg yaronyg removed this from the New Infra milestone Jun 20, 2016

@yaronyg yaronyg added 0 - Icebox and removed 3 - Working labels Jun 20, 2016

@yaronyg yaronyg removed their assignment Jun 20, 2016

@yaronyg yaronyg added the bug label Jun 20, 2016

@yaronyg yaronyg added this to the V1 milestone Aug 3, 2016

@yaronyg yaronyg added 1 - Backlog and removed 0 - Icebox labels Aug 4, 2016

@yaronyg yaronyg added Node and removed P1 labels Sep 26, 2016

@yaronyg yaronyg removed the 1 - Backlog label Oct 6, 2016

@yaronyg

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Oct 18, 2016

Member

It would certainly seem useful to return this data but I'm not 100% sure if it really matters at this point.

Member

yaronyg commented Oct 18, 2016

It would certainly seem useful to return this data but I'm not 100% sure if it really matters at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment