Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story 00 #138

Merged
merged 48 commits into from Sep 25, 2015
Merged

Story 00 #138

merged 48 commits into from Sep 25, 2015

Conversation

@yaronyg
Copy link
Member

@yaronyg yaronyg commented Sep 25, 2015

Just RI'ing from the approved story 00 to story 001

Review on Reviewable

Jukka Silvennoinen and others added 30 commits Sep 10, 2015
…nce tests are working fine, original tests do need a bit of tweaking still.
…ere is issue with tape hanging when attempted to be used with second instance.
… only called when all devices have finished testing.

Also small fix on tests erver side for checking that the variable is actually set before it is used added.
@tobybrad

This comment has been minimized.

Copy link
Contributor Author

@tobybrad tobybrad commented on bef0d4f Sep 21, 2015

I think (it may have been a bad build) I saw an issue that should be impossible where we attempt to invite a peer when our session is null.

@yaronyg yaronyg added the in progress label Sep 25, 2015
yaronyg added a commit that referenced this pull request Sep 25, 2015
@yaronyg yaronyg merged commit a7e9b2a into story_001 Sep 25, 2015
@yaronyg yaronyg removed the in progress label Sep 25, 2015
@evabishchevich evabishchevich deleted the story_00 branch Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.