/Thali_CordovaPlugin

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story 03 yarong 249 #333

Merged
merged 2 commits into from Dec 1, 2015

Conversation

Reviewers
No reviews
Assignees

@vjrantal vjrantal

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@yaronyg @ThaliTester @vjrantal
@yaronyg
Member

yaronyg commented Nov 17, 2015

Review on Reviewable

yaronyg added some commits Nov 14, 2015

@yaronyg
Just a backup 
This is my first rough sketch of how the WiFi based native layer mock
should work.
7c6ee97
@yaronyg
Finished up wifi mock proposal 
Also added a new error and fixed  jsdoc value in thaliMobileNative
cae1769
@ThaliTester

This comment has been minimized.

Show comment
Hide comment
@ThaliTester

ThaliTester Nov 17, 2015

Member

PR is added to the queue for testing as 1. task. (cae1769)
Member

ThaliTester commented Nov 17, 2015

PR is added to the queue for testing as 1. task. (cae1769)

@yaronyg yaronyg assigned yaronyg and vjrantal and unassigned yaronyg Nov 17, 2015

@yaronyg

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Nov 17, 2015

Member

@vjrantal This is the proposal for the wifi based mock of the native layer. Please review when you have time. Thanks!
Member

yaronyg commented Nov 17, 2015

@vjrantal This is the proposal for the wifi based mock of the native layer. Please review when you have time. Thanks!
@ThaliTester

This comment has been minimized.

Show comment
Hide comment
@ThaliTester

ThaliTester Nov 17, 2015

Member

Test (Success) 50907297 build is completed (cae1769)

See https://github.com/ThaliTester/TestResults/tree/50907297cae1769_Story_03_yarong_249_yaronyg/ for the logs
Member

ThaliTester commented Nov 17, 2015

Test (Success) 50907297 build is completed (cae1769)

See https://github.com/ThaliTester/TestResults/tree/50907297cae1769_Story_03_yarong_249_yaronyg/ for the logs
@ThaliTester

This comment has been minimized.

Show comment
Hide comment
@ThaliTester

ThaliTester Nov 17, 2015

Member

Test 50907297cae1769(cae1769) has failed

See https://github.com/ThaliTester/TestResults/tree/50907297cae1769_Story_03_yarong_249_yaronyg/ for the fail logs
Member

ThaliTester commented Nov 17, 2015

Test 50907297cae1769(cae1769) has failed

See https://github.com/ThaliTester/TestResults/tree/50907297cae1769_Story_03_yarong_249_yaronyg/ for the fail logs

@yaronyg yaronyg added the 1 - Backlog label Nov 18, 2015

@yaronyg yaronyg added 4 - Done and removed 1 - Backlog labels Dec 1, 2015

yaronyg added a commit that referenced this pull request Dec 1, 2015

@yaronyg
Merge pull request #333 from thaliproject/story_03_yarong_249 
Story 03 yarong 249
02068dc

@yaronyg yaronyg merged commit 02068dc into story_03_yarong Dec 1, 2015
1 check passed

1 check passed

code-review/gitcolony 0/0 qa 0/0 dev, 0 issues
Details

@yaronyg yaronyg deleted the story_03_yarong_249 branch Dec 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment