/Thali_CordovaPlugin

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story 0 sree #40

Closed
wants to merge 67 commits into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@sreesharp @yaronyg @mattpodwysocki @DrJukka @mpodwysocki @obastemur
@sreesharp
Contributor

sreesharp commented Jul 21, 2015

Adding cordova hook to setup the pre-requisites for thali_corodva plugin

mattpodwysocki and others added some commits Jun 19, 2015

@mattpodwysocki
Adding emitter
94626ed
@mattpodwysocki
Adding through getPeerIdentifier
b98ece4
@mattpodwysocki
Adding connecting events
37e7ad8
@mattpodwysocki
Refactoring connecting events
5911393
@mattpodwysocki
Fix parse events
775b808
@mattpodwysocki
Fix stop method name
1912a96
@mattpodwysocki
Add connect/disconnet to peer
52fc9c9
@yaronyg
Non-working story -1 test 
This includes sockettest.js which should pass to declare story -1
finished. It includes a simple local loop back test that just copies
data from a local TCP/IP client to a local TCP/IP server and while this
passes JXCore on the desktop it doesn’t pass on Android!
795bb0c
@yaronyg
Now actually working! 
Turns out there is a bug in JXCore that requires us to have a data
listener for server sockets even though we are automatically piping all
content. See jxcore/jxcore#411
c785f9b
@yaronyg
Changed getServerPortFunction to a promise 
In the previous design getServerPortFunction was a synchronous function
which wasn’t going to work for Story -1 which requires a bunch of
native code to set up local connections before it’s ready to work. We
needed an asynchronous function. So I changed the function to be a
promise.
c0d0da2
@mattpodwysocki
Initial commit replication manager
a3b5a3f
@mattpodwysocki
Merge branch 'master' of https://github.com/thaliproject/Thali_Cordov… 
…aPlugin into story_0_matthewp
b368509
@mattpodwysocki
Adding API docs
eaea700
@mattpodwysocki
Merge branch 'master' of https://github.com/thaliproject/Thali_Cordov… 
…aPlugin into story_0_matthewp
1e15103
@yaronyg
Merged with Jukka's latest master
74584c3
@mattpodwysocki
Updating sync manager
f52f51c
@mattpodwysocki
Updating cordova sync interface
c99201d
@mattpodwysocki
Fixing docs/code for Issue #17
fce8827
@mattpodwysocki
Adding mocks for Issue #17
75e3256
@yaronyg
Running story -1 and mix tests 
This is the code I used to get story -1 to pass.
It also contains the test code for the proposed muxing layer.
345803b
@mattpodwysocki
Merge branch 'master' of https://github.com/thaliproject/Thali_Cordov… 
…aPlugin into story_0_matthewp
8639dcc
@mattpodwysocki
Adding first test for startBroadcasting
665b018
@mattpodwysocki
Refactoring connection manager
5b08c22
@mattpodwysocki
Adding more tests
e86257e
@mattpodwysocki
Finished Thali Emitter Tests
c7a650c
@yaronyg
Added error handling in the mix layer 
This code is not properly tested at all. But I just wanted to get a
remote backup.
485ee09
@DrJukka
Implemented the Disconnect when Client TCP/IP socket is closed. 
Implemented a multiple incoming connections handling
Fixed a race condition with Nodejs starting client socket before the bridge is accepting the incoming local client TCP/IP connections.
ff968b6
@yaronyg
Running with mux layer on Android! 
This actually passed on Android using mux and Bluetooth!
169c3eb
@mattpodwysocki
Updating from yarong
00d72c4
@yaronyg
Clarify Android build instructions
5cbc729
@mpodwysocki
Merge pull request #18 from thaliproject/yaronyg-patch-1 
Clarify Android build instructions
65ea73f
@yaronyg
Setting ANDROID_HOME
3760d1b
@mpodwysocki
Merge pull request #19 from thaliproject/yaronyg-patch-2 
Setting ANDROID_HOME
33e6a16
@yaronyg
OS/X wants .bash_profile not .bashrc 
Terminal on OS/X always does a full login for some reason so you want to use .base_profile because .bashrc will never be run. Thanks to @obastemur for pointing this out!
f20312b
@obastemur
Merge pull request #20 from thaliproject/yaronyg-patch-3 
OS/X wants .bash_profile not .bashrc
077f2e5
@mattpodwysocki
So confused...
0247f97
@mattpodwysocki
Merge branch 'story_0_matthewp' of https://github.com/thaliproject/Th… 
…ali_CordovaPlugin into story_0_matthewp
4714ea1
@DrJukka
Cleaned up the sample a bit.
de8ca85
@mattpodwysocki
Merging from Jukka
e5f17c0
@mattpodwysocki
Merging readme
2d76591
@yaronyg

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Jul 8, 2015

Member

Please revert this entire change to the file. It completely shredded it! Lines are cut off. Important information is deleted. It's a mess. Please roll it back.
Member

yaronyg commented on README.md in 2d76591 Jul 8, 2015

Please revert this entire change to the file. It completely shredded it! Lines are cut off. Important information is deleted. It's a mess. Please roll it back.

This comment has been minimized.

Show comment
Hide comment
@mattpodwysocki

mattpodwysocki Jul 24, 2015

Contributor

👍
Contributor

mattpodwysocki replied Jul 24, 2015

👍

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Jul 24, 2015

Member

Sigh.... :P Don't mess with the review system!!!!
Member

yaronyg replied Jul 24, 2015

Sigh.... :P Don't mess with the review system!!!!

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Jul 24, 2015

Member

👍
Member

yaronyg replied Jul 24, 2015

👍

@sreesharp sreesharp added the in progress label Jul 21, 2015

@yaronyg

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Jul 23, 2015

Member

This PR is committing to the wrong branch. It should be to story_0 not master.
Member

yaronyg commented Jul 23, 2015

This PR is committing to the wrong branch. It should be to story_0 not master.

@yaronyg yaronyg closed this Jul 23, 2015

@yaronyg yaronyg removed the in progress label Jul 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment