This repository has been archived by the owner. It is now read-only.
Story 0 sree #40
Closed
Story 0 sree #40
Conversation
This includes sockettest.js which should pass to declare story -1 finished. It includes a simple local loop back test that just copies data from a local TCP/IP client to a local TCP/IP server and while this passes JXCore on the desktop it doesn’t pass on Android!
Turns out there is a bug in JXCore that requires us to have a data listener for server sockets even though we are automatically piping all content. See jxcore/jxcore#411
In the previous design getServerPortFunction was a synchronous function which wasn’t going to work for Story -1 which requires a bunch of native code to set up local connections before it’s ready to work. We needed an asynchronous function. So I changed the function to be a promise.
…aPlugin into story_0_matthewp
…aPlugin into story_0_matthewp
This is the code I used to get story -1 to pass. It also contains the test code for the proposed muxing layer.
…aPlugin into story_0_matthewp
This code is not properly tested at all. But I just wanted to get a remote backup.
Implemented a multiple incoming connections handling Fixed a race condition with Nodejs starting client socket before the bridge is accepting the incoming local client TCP/IP connections.
This actually passed on Android using mux and Bluetooth!
This comment has been minimized.
This comment has been minimized.
Please revert this entire change to the file. It completely shredded it! Lines are cut off. Important information is deleted. It's a mess. Please roll it back. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Sigh.... :P Don't mess with the review system!!!! |
This comment has been minimized.
This comment has been minimized.
|
…fy the version of SDK now.
This PR is committing to the wrong branch. It should be to story_0 not master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Adding cordova hook to setup the pre-requisites for thali_corodva plugin