New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story 0 sree #40

Closed
wants to merge 67 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@sreesharp
Contributor

sreesharp commented Jul 21, 2015

Adding cordova hook to setup the pre-requisites for thali_corodva plugin

mattpodwysocki and others added some commits Jun 19, 2015

Non-working story -1 test
This includes sockettest.js which should pass to declare story -1
finished. It includes a simple local loop back test that just copies
data from a local TCP/IP client to a local TCP/IP server and while this
passes JXCore on the desktop it doesn’t pass on Android!
Now actually working!
Turns out there is a bug in JXCore that requires us to have a data
listener for server sockets even though we are automatically piping all
content. See jxcore/jxcore#411
Changed getServerPortFunction to a promise
In the previous design getServerPortFunction was a synchronous function
which wasn’t going to work for Story -1 which requires a bunch of
native code to set up local connections before it’s ready to work. We
needed an asynchronous function. So I changed the function to be a
promise.
Running story -1 and mix tests
This is the code I used to get story -1 to pass.
It also contains the test code for the proposed muxing layer.
Added error handling in the mix layer
This code is not properly tested at all. But I just wanted to get a
remote backup.
Implemented the Disconnect when Client TCP/IP socket is closed.
Implemented a multiple incoming connections handling
Fixed a race condition with Nodejs starting client socket before the bridge is accepting the incoming local client TCP/IP connections.
Running with mux layer on Android!
This actually passed on Android using mux and Bluetooth!
Merge pull request #18 from thaliproject/yaronyg-patch-1
Clarify Android build instructions
OS/X wants .bash_profile not .bashrc
Terminal on OS/X always does a full login for some reason so you want to use .base_profile because .bashrc will never be run. Thanks to @obastemur for pointing this out!
Merge pull request #20 from thaliproject/yaronyg-patch-3
OS/X wants .bash_profile not .bashrc
@yaronyg

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Jul 8, 2015

Member

Please revert this entire change to the file. It completely shredded it! Lines are cut off. Important information is deleted. It's a mess. Please roll it back.

Member

yaronyg commented on README.md in 2d76591 Jul 8, 2015

Please revert this entire change to the file. It completely shredded it! Lines are cut off. Important information is deleted. It's a mess. Please roll it back.

This comment has been minimized.

Show comment
Hide comment
@mattpodwysocki

mattpodwysocki Jul 24, 2015

Contributor

👍

Contributor

mattpodwysocki replied Jul 24, 2015

👍

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Jul 24, 2015

Member

Sigh.... :P Don't mess with the review system!!!!

Member

yaronyg replied Jul 24, 2015

Sigh.... :P Don't mess with the review system!!!!

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Jul 24, 2015

Member

👍

Member

yaronyg replied Jul 24, 2015

👍

@yaronyg

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Jul 23, 2015

Member

This PR is committing to the wrong branch. It should be to story_0 not master.

Member

yaronyg commented Jul 23, 2015

This PR is committing to the wrong branch. It should be to story_0 not master.

@yaronyg yaronyg closed this Jul 23, 2015

@yaronyg yaronyg removed the in progress label Jul 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment