New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story 00 juksilve #66

Closed
wants to merge 2 commits into
base: story_00
from

Conversation

Projects
None yet
2 participants
@DrJukka
Contributor

DrJukka commented Aug 12, 2015

changes made are described in comments

  

@DrJukka DrJukka added the in progress label Aug 12, 2015

@yaronyg

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Aug 12, 2015

Member

@DrJukka - It would appear that when you renamed the files you did it by delete and then rename (as opposed to a GIT mv) and this PR only seems to have the delete, not the rename part. Please update the commit with the renamed files.

Member

yaronyg commented Aug 12, 2015

@DrJukka - It would appear that when you renamed the files you did it by delete and then rename (as opposed to a GIT mv) and this PR only seems to have the delete, not the rename part. Please update the commit with the renamed files.

@yaronyg

This comment has been minimized.

Show comment
Hide comment
@yaronyg

yaronyg Aug 13, 2015

Member

@DrJukka - I don't see an update to this. Can we close it for now?

Member

yaronyg commented Aug 13, 2015

@DrJukka - I don't see an update to this. Can we close it for now?

@DrJukka

This comment has been minimized.

Show comment
Hide comment
@DrJukka

DrJukka Aug 13, 2015

Contributor

from my point of view, surely we could close it

Contributor

DrJukka commented Aug 13, 2015

from my point of view, surely we could close it

@DrJukka DrJukka closed this Aug 13, 2015

@DrJukka DrJukka removed the in progress label Aug 13, 2015

@DrJukka DrJukka deleted the story_00_juksilve branch Aug 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment