Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and hardening #720

Merged
merged 150 commits into from Jul 29, 2016
Merged

Fixes and hardening #720

merged 150 commits into from Jul 29, 2016

Conversation

@tompaana
Copy link
Member

@tompaana tompaana commented Apr 27, 2016

  • Set a custom manufacturer ID for BLE advertisements
  • Fixed #659
  • Fixed #657
  • Fixed #642

This change is Reviewable

@msftclas
Copy link

@msftclas msftclas commented Apr 27, 2016

Hi @tompaana, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Paananen Tomi (DX/Tampere)). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@ThaliTester
Copy link
Member

@ThaliTester ThaliTester commented Apr 27, 2016

PR is added to the queue for testing as 1. task. (efa6102)

@yaronyg yaronyg added the in progress label Apr 27, 2016
@tompaana tompaana added this to the New Infra milestone Apr 27, 2016
@tompaana tompaana added the 2 - Ready label Apr 27, 2016
@ThaliTester
Copy link
Member

@ThaliTester ThaliTester commented Apr 27, 2016

@yaronyg yaronyg added 3 - Working and removed 2 - Ready labels Apr 28, 2016
@yaronyg
Copy link
Member

@yaronyg yaronyg commented Apr 28, 2016

I'm out of time for tonight and I want to take my time with Streamcopyingthread and socketthreadbase per our previously conversation. So I'll review them tomorrow.


Reviewed 9 of 11 files at r1.
Review status: 9 of 11 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.


src/android/java/io/jxcore/node/StartStopOperationHandler.java, line 221 [r1] (raw file):
Shouldn't overflow go to 0 not 1?


test/www/jxcore/bv_tests/testThaliMobileNativeWrapper.js, line 714 [r1] (raw file):
/ran/run


test/www/jxcore/bv_tests/testThaliMobileNativeWrapper.js, line 716 [r1] (raw file):
This shouldn't be possible. listenerRecreatedAfterFailure is what triggers us to fire the new nonTCPPeerAvailabilityChangedEvent. Go look at the function listenerRecreatedAfterFailureHandler in thaliMobileNativeWrapper. So something else isn't going right here. We need to understand what.


Comments from Reviewable

…ple_issues

# Conflicts:
#	thali/package.json
@ThaliTester
Copy link
Member

@ThaliTester ThaliTester commented Apr 28, 2016

PR is added to the queue for testing as 1. task. (b92179b)

@ThaliTester
Copy link
Member

@ThaliTester ThaliTester commented Apr 28, 2016

@ThaliTester
Copy link
Member

@ThaliTester ThaliTester commented Apr 28, 2016

@ThaliTester
Copy link
Member

@ThaliTester ThaliTester commented Apr 28, 2016

PR is added to the queue for testing as 1. task. (aff19f4)

@ThaliTester
Copy link
Member

@ThaliTester ThaliTester commented Apr 28, 2016

@ThaliTester
Copy link
Member

@ThaliTester ThaliTester commented Apr 28, 2016

jareksl and others added 8 commits Jul 26, 2016
Commented out compilation for iOS
Commented out copy of app for iOS
V next jareksl 555 clean
…aana_multiple_issues

# Conflicts:
#	thali/package.json
Fixed some tests, added toString test in StartStop operation
@ThaliTester
Copy link
Member

@ThaliTester ThaliTester commented Jul 27, 2016

PR is added to the queue for testing as 2. task. (3e34e91)

@ThaliTester
Copy link
Member

@ThaliTester ThaliTester commented Jul 27, 2016

@evabishchevich
Copy link
Member

@evabishchevich evabishchevich commented Jul 27, 2016

Review status: 11 of 50 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


src/android/java/io/jxcore/node/OutgoingSocketThread.java, line 81 [r7] (raw file):

Previously, yaronyg (Yaron Y Goland) wrote…

How exactly would we end up with a null pointer exception?

There is no possibility to get NPE

Comments from Reviewable

@yaronyg
Copy link
Member

@yaronyg yaronyg commented Jul 27, 2016

@evabishchevich I'm going to hold off on reviewing this until 555 is checked in. Most of the diffs here are caused by your merge with 555 and so I would just be reviewing the same changes twice. Instead we'll wait for 555 to go into vNext and then this should only show changes post 555.


Reviewed 1 of 39 files at r11.
Review status: 12 of 50 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


src/android/java/io/jxcore/node/StartStopOperationHandler.java, line 221 [r1] (raw file):

Previously, evabishchevich wrote…

Tomi used 1 instead of 0 because there is the constant NO_EXTRA_INFORMATION = 0 in PeerProperties in BtLibrary. 0 looks like reserved value

Reserved for what purpose? Also, how can we just delete this code? How do we deal with state roll over?

Comments from Reviewable

Eugene Vabishchevich
@ThaliTester
Copy link
Member

@ThaliTester ThaliTester commented Jul 28, 2016

PR is added to the queue for testing as 3. task. (40493cb)

Eugene Vabishchevich
@ThaliTester
Copy link
Member

@ThaliTester ThaliTester commented Jul 28, 2016

PR is added to the queue for testing as 3. task. (ea857b4)

@ThaliTester
Copy link
Member

@ThaliTester ThaliTester commented Jul 28, 2016

@ThaliTester
Copy link
Member

@ThaliTester ThaliTester commented Jul 28, 2016

Test 6810213040493cb(40493cb) has successfully finished without an error

See https://github.com/ThaliTester/TestResults/tree/6810213040493cb_Fixes_and_hardening_tompaana/ for the logs

@ThaliTester
Copy link
Member

@ThaliTester ThaliTester commented Jul 28, 2016

@ThaliTester
Copy link
Member

@ThaliTester ThaliTester commented Jul 28, 2016

Test 68102130ea857b4(ea857b4) has successfully finished without an error

See https://github.com/ThaliTester/TestResults/tree/68102130ea857b4_Fixes_and_hardening_tompaana/ for the logs

@yaronyg
Copy link
Member

@yaronyg yaronyg commented Jul 29, 2016

@evabishchevich There is just one open issue left and it's really a question. Once we have settled that question then consider this good to check in.


Reviewed 23 of 39 files at r11, 4 of 27 files at r12, 22 of 23 files at r13, 1 of 1 files at r14.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


src/android/java/io/jxcore/node/StartStopOperationHandler.java, line 221 [r1] (raw file):

Previously, yaronyg (Yaron Y Goland) wrote…

Reserved for what purpose? Also, how can we just delete this code? How do we deal with state roll over?

I still need to understand what purpose Tomi was using the 0 for and why he couldn't set extraInformation to 0. Please don't check in until we have this fully clarified.

Comments from Reviewable

@yaronyg yaronyg removed their assignment Jul 29, 2016
@yaronyg yaronyg merged commit a6bbc33 into vNext Jul 29, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
code-review/reviewable 2 discussions left (evabishchevich, yaronyg)
Details
@yaronyg yaronyg removed the in progress label Jul 29, 2016
@evabishchevich evabishchevich deleted the vNext_tompaana_multiple_issues branch Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.