Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support __OwningControllerProcess #1

Closed
yaronyg opened this issue Jul 8, 2014 · 2 comments
Closed

Support __OwningControllerProcess #1

yaronyg opened this issue Jul 8, 2014 · 2 comments
Labels

Comments

@yaronyg
Copy link
Member

yaronyg commented Jul 8, 2014

On the desktop we should be able to make a platform specific call to get our PID and then pass that in using the __OwningControllerProcess argument to the Tor OP so it will confirm that the PID exists or exit. This is needed to handle a race condition where the parent creates the Tor OP and dies before issuing the TAKEOWNERSHIP command.

If we don't want to go this route then we need to actually implement killZombieProcess which is kind of scary since it requires scraping PS and killing stuff.

The ideal solution however would be for https://trac.torproject.org/projects/tor/ticket/12572 so we need to track that too

@yaronyg yaronyg added the bug label Jul 8, 2014
@yaronyg
Copy link
Member Author

yaronyg commented Jul 10, 2014

Michael Rogers from Briar already updated Briar to support __OwningControllerProcess so we just need to go and grab that code.

@yaronyg
Copy link
Member Author

yaronyg commented Jul 15, 2014

I actually already added in the code but I'll close this bug when I submit the PR.

@yaronyg yaronyg added this to the v0.0.0. release milestone Jul 15, 2014
yaronyg pushed a commit that referenced this issue Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant