This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
forked from jxcore/jxcore
-
Notifications
You must be signed in to change notification settings - Fork 4
Externalize the paths #8
Comments
First hardcoded path I run into while working on thaliproject/Thali_CordovaPlugin#763 is in this script:
while https://github.com/jxcore/jxcore/blob/master/tools/npmjx/index.js contains:
(btw, that returns an AccessDenied error). |
There is also https://github.com/thaliproject/jxcore/blob/master/lib/jx/_jx_install.js that contains hardcoded strings:
_jx_install.js in turn calls npmjx/index.js. |
The solution consists of:
|
enricogior
added a commit
that referenced
this issue
Aug 2, 2016
Jxcore uses its own npm version and the urls to the modules were hardcoded. Issue #8
enricogior
added a commit
that referenced
this issue
Aug 2, 2016
Jxcore uses its own npm version and the urls to the modules were hardcoded. Issue #8
enricogior
added a commit
that referenced
this issue
Aug 2, 2016
Jxcore uses its own npm version and the urls to the modules were hardcoded. Issue #8
enricogior
added a commit
that referenced
this issue
Aug 2, 2016
Jxcore uses its own npm version and the urls to the modules were hardcoded. Issue #8
enricogior
added a commit
that referenced
this issue
Aug 2, 2016
Jxcore uses its own npm version and the urls to the modules were hardcoded. Issue #8
PR submitted. |
enricogior
added a commit
that referenced
this issue
Aug 8, 2016
A previous change to the Makefile for Issue #8 is not working when building Android on macOS.
enricogior
added a commit
that referenced
this issue
Aug 8, 2016
A previous change to the Makefile for Issue #8 is not working when building Android on macOS.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Right now we hardcode in paths pointing to our distribution points during the build. That would be what is known as 'bad'. :) We need to submit a PR to JXcore that lets us set the paths in some kind of external configuration file so that different people who download JXcore can choose to point at whatever location they want. I found at least three files in JXcore forexample that point directly at azureedge.net. But that is an endpoint owned by Microsoft. It's not something that should be in the general JXcore repo. Instead those values should point at configuration files that someone building JXcore can set up and then do a compile and produce an output that points where ever they want.
By externalizing this we can keep the JXcore build agonist from Microsoft which is what we want. We are absolutely NOT promising the world to host JXcore! :)
The text was updated successfully, but these errors were encountered: