New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect dry run, allow pull on locked stack #207

Merged
merged 6 commits into from May 12, 2015

Conversation

Projects
None yet
2 participants
@cakirke
Contributor

cakirke commented May 4, 2015

proposed solution for #166, i think pattern would apply to other actions (add, update, etc.) if needed

Show outdated Hide outdated lib/Pinto/Action/Pull.pm Outdated
Show outdated Hide outdated lib/Pinto/Action/Update.pm Outdated
Show outdated Hide outdated lib/Pinto/Action/Pull.pm Outdated
$t->run_ok( 'Lock' => {} );
$t->stack_is_locked_ok('master');
$t->run_ok( 'Add', { archives => $archive, dry_run => 1 } );
$t->registration_not_ok("AUTHOR/$dist/$pkg1/master");

This comment has been minimized.

@thaljef

thaljef May 6, 2015

Owner

Asserting that something is not registered is a bit sketchy, since it is easy to get a false positive if you happen to mistype something in the test. It might be more robust to use repository_clean_ok to assert that the repo is still in a virgin state after the operation. What do you think?

@thaljef

thaljef May 6, 2015

Owner

Asserting that something is not registered is a bit sketchy, since it is easy to get a false positive if you happen to mistype something in the test. It might be more robust to use repository_clean_ok to assert that the repo is still in a virgin state after the operation. What do you think?

This comment has been minimized.

@cakirke

cakirke May 7, 2015

Contributor

agreed - didn't get up to speed on all of the Pinto::Tester helpers, also valid for previous change to 21-pull.t, fixing now

@cakirke

cakirke May 7, 2015

Contributor

agreed - didn't get up to speed on all of the Pinto::Tester helpers, also valid for previous change to 21-pull.t, fixing now

thaljef added a commit that referenced this pull request May 12, 2015

Merge pull request #207 from cakirke/issue-166-dry-run-lock
respect dry run, allow pull on locked stack

@thaljef thaljef merged commit 959eba3 into thaljef:master May 12, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

thaljef added a commit that referenced this pull request Jun 10, 2015

v0.09998
      [THANKS]

      Several of the changes in this release were contributed by Chris Kirke as
      part of the CPAN Pull Request Challenge, organized by Neil Bowers. I am
      sincerely grateful for their efforts.

      [BUG FIXES]

      - The t/, xt/, inc, and local/ directories are always ignored when
        indexing a distribution. This is exactly what PAUSE does.

      - Fixed test failures caused by the presence of a ~/.pause file. GH #172.

      [NEW COMMANDS]

      - The "look" command will unpack a distribution into a temporary directory
      and spawn a subshell in that location.  Contributed by Kal Hodgson.

      [ENHANCMENTS]

      - The "diff" command now has a --format option for more precise control
      of the output. Contributed by Florian Ragwitz.

      - A stale repository lockfile can be stollen if the PINTO_STALE_LOCKFILE_TIMEOUT
      environment variable is set. Contributed by Chris Kirke. GH #209.

      - Operations with the --dry-run option are now allowed on locked stacks.
      Contributed by Chris Kirke. GH #207.

      - Improved error messages when a repository is not in a sane state.
      Contributed by Chris Kirke. GH #199.

      - Improved latency from Pinto::Server by autoflushing the output.

      [PREREQUISITES]

      - Several of the prerequisite modules have been upgraded to newer versions
      to take advantage of recent improvements, and to support Perl 5.22.0. If
      you have installed Pinto as a stand-alone application as described in
      Pinto::Manual::Installing then your environment will be insulated from these
      upgrades.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment