Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punch in time from the tray icon #55

Closed
thamara opened this issue Oct 19, 2019 · 7 comments
Closed

Punch in time from the tray icon #55

thamara opened this issue Oct 19, 2019 · 7 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest
Milestone

Comments

@thamara
Copy link
Owner

thamara commented Oct 19, 2019

It should be possible to punch in time from the icon on the tray, by right clicking it and selection an option 'Punch in time'. This way the user don't even need to open the app.

@thamara thamara added enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest labels Oct 19, 2019
@VicoErv
Copy link
Contributor

VicoErv commented Oct 19, 2019

what do you mean by 'Puch in time' ? is it showing the time in the tray context menu? or by clicking that menu, will open a dialog that show the time data for today?

@tupaschoal
Copy link
Collaborator

@VicoErv the app has a big button at the bottom that allows you to "punch-in" and stamp the current time as you're entering or exiting. This action should also be available from the tray context menu.

@VicoErv
Copy link
Contributor

VicoErv commented Oct 19, 2019

@tupaschoal i got it, do i need to show dialog confirmation or success dialog after that?

@tupaschoal
Copy link
Collaborator

@VicoErv I'd say a brief tooltip is nice, as users have no visual indicators it worked, because the app is minimized. A dialog seems too much

@VicoErv
Copy link
Contributor

VicoErv commented Oct 19, 2019

thank you @tupaschoal, i've made a pull request for this.

@thamara
Copy link
Owner Author

thamara commented Oct 19, 2019

I think a notification would be good in this case. A notification similar to the one used to inform the user it's time to leave.

@tupaschoal tupaschoal added this to the Version 1.2.0 milestone Oct 19, 2019
@tupaschoal
Copy link
Collaborator

Closed with #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants