Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change JS filenames to bring them in line with the Google JavaScript … #116

Merged
merged 3 commits into from Oct 27, 2019

Conversation

@danielimmke
Copy link
Contributor

danielimmke commented Oct 24, 2019

…Style Guide.

Related issue

#115

Context / Background

  • I also removed capitalized files to standardize them all.

What change is being introduced by this PR?

  • Renaming files to comply with the Google JavaScript style guide and updating their references in other files to the new filenames.

How will this be tested?

  • The application worked when I ran npm start, I also ran the lint command which came back clean.
Copy link
Collaborator

tupaschoal left a comment

We already have time_math.js which is separated by an underscore, so I'd say we should standardize on it. (With this PR there would be dashes and underscores)

@thamara

This comment has been minimized.

Copy link
Owner

thamara commented Oct 24, 2019

I actually think time_math should be standardize to time-math. Node's project seem to prefer the -, so, although we can choose between - and _, I would prefer -.

@danielimmke danielimmke requested a review from tupaschoal Oct 24, 2019
@thamara thamara merged commit 98d34e0 into thamara:master Oct 27, 2019
9 checks passed
9 checks passed
build (8.x, ubuntu-latest)
Details
build (8.x, windows-latest)
Details
build (8.x, macOS-latest)
Details
build (10.x, ubuntu-latest)
Details
build (10.x, windows-latest)
Details
build (10.x, macOS-latest)
Details
build (12.x, ubuntu-latest)
Details
build (12.x, windows-latest)
Details
build (12.x, macOS-latest)
Details
@thamara

This comment has been minimized.

Copy link
Owner

thamara commented Oct 27, 2019

Thanks @danielimmke !

@thamara thamara added this to the Version 1.3.0 milestone Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.