Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added translation keys for FixedDayCalendar.js and Calendar.js #450

Merged
merged 4 commits into from Oct 12, 2020
Merged

Added translation keys for FixedDayCalendar.js and Calendar.js #450

merged 4 commits into from Oct 12, 2020

Conversation

BamButz
Copy link
Contributor

@BamButz BamButz commented Oct 12, 2020

Related issue

Closes #433

Context / Background

See issue #433

What change is being introduced by this PR?

Added keys for translation purposes

How will this be tested?

Start the application and keep looking for missing translations

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #450 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #450   +/-   ##
=======================================
  Coverage   63.95%   63.95%           
=======================================
  Files          28       28           
  Lines        2536     2536           
  Branches      389      389           
=======================================
  Hits         1622     1622           
  Misses        806      806           
  Partials      108      108           
Impacted Files Coverage Δ
js/classes/Calendar.js 73.82% <100.00%> (ø)
js/classes/FixedDayCalendar.js 97.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa91728...4181bdb. Read the comment docs.

Copy link
Owner

@thamara thamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good already, but there are a few things I would like you to change.

js/classes/Calendar.js Outdated Show resolved Hide resolved
locales/en/translation.json Outdated Show resolved Hide resolved
locales/pt-BR/translation.json Outdated Show resolved Hide resolved
locales/en/translation.json Outdated Show resolved Hide resolved
removed $FixedCalendar from translation.json

added indent_size of 2 for json files
Copy link
Owner

@thamara thamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from these last changes, I think everything looks great!

locales/en/translation.json Outdated Show resolved Hide resolved
locales/pt-BR/translation.json Outdated Show resolved Hide resolved
js/classes/Calendar.js Outdated Show resolved Hide resolved
js/classes/FixedDayCalendar.js Outdated Show resolved Hide resolved
locales/en/translation.json Outdated Show resolved Hide resolved
locales/pt-BR/translation.json Outdated Show resolved Hide resolved
renamed keys
@thamara
Copy link
Owner

thamara commented Oct 12, 2020

\changelog-update
User: BamButz

@thamara thamara merged commit 0f5b4a6 into thamara:main Oct 12, 2020
@thamara
Copy link
Owner

thamara commented Oct 12, 2020

Thanks a lot!

thamara pushed a commit to jcombs0929/time-to-leave that referenced this pull request Oct 17, 2020
…ra#450)

* Added translation keys for FixedDayCalendar.js and Calendar.js

* Fixed wrong translation keys

* changed translation key working-days-left to working-days-count

removed $FixedCalendar from translation.json

added indent_size of 2 for json files

* removed unused keys

renamed keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare Calendar.js for localization
2 participants