New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added translation keys for FixedDayCalendar.js and Calendar.js #450
Conversation
Codecov Report
@@ Coverage Diff @@
## main #450 +/- ##
=======================================
Coverage 63.95% 63.95%
=======================================
Files 28 28
Lines 2536 2536
Branches 389 389
=======================================
Hits 1622 1622
Misses 806 806
Partials 108 108
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good already, but there are a few things I would like you to change.
removed $FixedCalendar from translation.json added indent_size of 2 for json files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from these last changes, I think everything looks great!
renamed keys
\changelog-update |
Thanks a lot! |
…ra#450) * Added translation keys for FixedDayCalendar.js and Calendar.js * Fixed wrong translation keys * changed translation key working-days-left to working-days-count removed $FixedCalendar from translation.json added indent_size of 2 for json files * removed unused keys renamed keys
Related issue
Closes #433
Context / Background
See issue #433
What change is being introduced by this PR?
Added keys for translation purposes
How will this be tested?
Start the application and keep looking for missing translations