Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go Report Card badge on Readme #17

Closed
thamaraiselvam opened this issue Oct 31, 2019 · 5 comments
Closed

Update Go Report Card badge on Readme #17

thamaraiselvam opened this issue Oct 31, 2019 · 5 comments

Comments

@thamaraiselvam
Copy link
Owner

@thamaraiselvam thamaraiselvam commented Oct 31, 2019

Update Go Report Card badge on Readme file

Reference:
https://goreportcard.com/badge/github.com/thamaraiselvam/github-api-cli?style=flat-square

Currently, Other batches are using style=for-the-badge but goreportcard does not support that style.
but style=flat-square looks very similar, maybe adding width and height on the image, can make it look alike other batches.
PR From FIRST TIME CONTRIBUTORS Welcome.

@andrewgcodes

This comment has been minimized.

Copy link
Contributor

@andrewgcodes andrewgcodes commented Oct 31, 2019

Claimed

@thamaraiselvam thamaraiselvam changed the title Update Go Report Card Batch on Readme Update Go Report Card badge on Readme Oct 31, 2019
@hasanadeem

This comment has been minimized.

Copy link

@hasanadeem hasanadeem commented Nov 2, 2019

Gave both badges a static height and width similar to other badges. Does this look good to you?

image

P.S. I'm a newbie contributor.

@thamaraiselvam

This comment has been minimized.

Copy link
Owner Author

@thamaraiselvam thamaraiselvam commented Nov 2, 2019

@hasanadeem I appreciate your contribution.

Already there is a PR raised #19 he has changed all existing badge size to style=flat-square. but he did not add a go report card yet.

can you raise a pull request by adding it?

thamaraiselvam added a commit that referenced this issue Nov 2, 2019
Update Go Report Card Update README.md #17
@thamaraiselvam

This comment has been minimized.

Copy link
Owner Author

@thamaraiselvam thamaraiselvam commented Nov 4, 2019

@hasanadeem Are you working on it?

@thamaraiselvam

This comment has been minimized.

Copy link
Owner Author

@thamaraiselvam thamaraiselvam commented Nov 7, 2019

resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.