Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compactor, store gw: Add deduplication replica label flags and delete delay flags #105

Merged
merged 3 commits into from
Mar 24, 2020
Merged

compactor, store gw: Add deduplication replica label flags and delete delay flags #105

merged 3 commits into from
Mar 24, 2020

Conversation

kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Mar 24, 2020 •
edited
Loading

Adds flags for recently introduces features:

  • offline deduplication
  • block delete delay
  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Offline deduplication replica labels flag bf72820
  • Delete delay flags 0c9bee8

Verification

  • make generate

@kakkoyun kakkoyun changed the title WIP: compactor: Add deduplication replica label flags compactor, store: Add deduplication replica label flags and delete delay labels Mar 24, 2020
@kakkoyun
Add deduplication replica label flags
25c6f1f 
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
@kakkoyun
Add delete delay flags
0c9bee8 
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
@kakkoyun
Update Changelog
bf72820 
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
This was referenced Mar 24, 2020
Closed
Merged
@kakkoyun kakkoyun marked this pull request as ready for review March 24, 2020 15:52
brancz
brancz approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 lgtm but giving others a chance to review

@kakkoyun kakkoyun changed the title compactor, store: Add deduplication replica label flags and delete delay labels compactor, store gw: Add deduplication replica label flags and delete delay labels Mar 24, 2020
@kakkoyun kakkoyun changed the title compactor, store gw: Add deduplication replica label flags and delete delay labels compactor, store gw: Add deduplication replica label flags and delete delay flags Mar 24, 2020
metalmatze
metalmatze approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! :)

@kakkoyun kakkoyun merged commit 00fe1af into thanos-io:master Mar 24, 2020
@kakkoyun kakkoyun deleted the dedup branch March 24, 2020 16:02
kakkoyun added a commit to kakkoyun/kube-thanos that referenced this pull request Apr 8, 2020
@kakkoyun
compactor, store gw: Add deduplication replica label flags and delete…
f5535cf 
… delay flags (thanos-io#105)

* Add deduplication replica label flags

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Add delete delay flags

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Update Changelog

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalmatze metalmatze metalmatze approved these changes

@brancz brancz brancz approved these changes

@squat squat squat approved these changes

@bwplotka bwplotka Awaiting requested review from bwplotka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kakkoyun @metalmatze @brancz @squat