Add method to explain query vector #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ExplainOutputNode struct with OperatorName and Children, A method `explainVector` generates `ExplainOutputNode` for the provided `VectorOperator`. This `explainVector` method is used by `Explain` method of query to get an explaination of the query. Signed-off-by: Pradyumna Krishna <git@onpy.in>
fpetkovski
reviewed
May 2, 2023
engine/engine.go
Outdated
| func explainVector(v model.VectorOperator) *ExplainOutputNode { | ||
| name, vectors := v.Explain() | ||
|
|
||
| var childs []ExplainOutputNode |
Collaborator
There was a problem hiding this comment.
Suggested change
| var childs []ExplainOutputNode | |
| var children []ExplainOutputNode |
engine/engine.go
Outdated
|
|
||
| var childs []ExplainOutputNode | ||
| for _, vector := range vectors { | ||
| childs = append(childs, *explainVector(vector)) |
Collaborator
There was a problem hiding this comment.
Can explainVector return nil?
GiedriusS
reviewed
May 2, 2023
Member
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
Maybe we could add some tests for this e.g. Explain() on a query that hasn't been executed yet, Explain() on a query that has one operator, Explain() on a "regular" query like sum(up) by (job).
Adds json key `name` to `OperatorName` and `children` to `Children` in `ExplainOutputNode`. Variable name correction in `explainVector` method. Signed-off-by: Pradyumna Krishna <git@onpy.in>
Test cases are added to Query Explain method to ensure working of the new query explain method. Signed-off-by: Pradyumna Krishna <git@onpy.in>
Contributor
Author
|
I guess the query |
Member
I think we could use |
Calculate concurrencyOperators according to max available CPUs. Signed-off-by: Pradyumna Krishna <git@onpy.in>
GiedriusS
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ExplainOutputNode struct with OperatorName and Children, A method
explainVectorgeneratesExplainOutputNodefor the providedVectorOperator.This
explainVectormethod is used byExplainmethod of query to get an explaination of the query.