From 7fe203474d25bbf8f3c94b5f465c32e2614b17ef Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Giedrius=20Statkevi=C4=8Dius?=
 <giedrius.statkevicius@vinted.com>
Date: Fri, 9 Feb 2024 15:39:08 +0200
Subject: [PATCH] docs: add post-mortem for avoid global sort and move it
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Long overdue TODO task for me - adding a post-mortem for the avoid
global sort proposal and move it to the "proposals-done" directory.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
---
 .../20221129-avoid-global-sort.md             | 30 +++++++++++++++++--
 1 file changed, 28 insertions(+), 2 deletions(-)
 rename docs/{proposals-accepted => proposals-done}/20221129-avoid-global-sort.md (89%)

diff --git a/docs/proposals-accepted/20221129-avoid-global-sort.md b/docs/proposals-done/20221129-avoid-global-sort.md
similarity index 89%
rename from docs/proposals-accepted/20221129-avoid-global-sort.md
rename to docs/proposals-done/20221129-avoid-global-sort.md
index 1a56a74140d..a8f94b6b6a3 100644
--- a/docs/proposals-accepted/20221129-avoid-global-sort.md
+++ b/docs/proposals-done/20221129-avoid-global-sort.md
@@ -1,9 +1,9 @@
 ---
 type: proposal
 title: Avoid Global Sort on Querier Select
-status: approved
+status: reverted
 owner: bwplotka,fpetkovski
-menu: proposals-accepted
+menu: proposals-done
 ---
 
 ## Avoid Global Sort on Querier Select
@@ -186,3 +186,29 @@ set := &promSeriesSet{
 	warns: warns,
 }
 ```
+
+## Post-mortem of proposal
+
+We initiated an early version of this but immediately ran into validity issues. The root of the problem, which resulted in inaccurate query responses, was that removing (or adding) labels to a set of labelsets potentially scrambled the order. This affected deduplication since it depends on receiving the series in an organized sequence. In simpler terms, to accurately duplicate, we need to be aware at all times if we have received all replicas for a given labelset; thus, deduplication only functions properly on organized series sets.
+
+Let's consider we have the following series labels:
+
+```
+a=1,b=1
+a=1,b=2
+a=2,b=1
+a=2,b=2
+```
+
+If the replica label is `a`, then the response transforms into:
+
+```
+b=1
+b=2
+b=1
+b=2
+```
+
+Theoretically, we could address this in the distant future by modifying the ordering rules within the TSDB, but I'm uncertain if that will ever materialize.
+
+Nevertheless, despite the initial challenges faced in implementation and subsequent reverting, we have made significant improvements to the querying internals. For example, we now use a ProxyHeap in a multitude of components, rather than repeating the same logic across each individual component.