Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucket web view behind reverse proxy #1349

Open
jdel opened this issue Jul 24, 2019 · 3 comments

Comments

@jdel
Copy link

commented Jul 24, 2019

First of all, thanks to everyone who worked on #1248, pretty cool feature ! Helpful a ton for troubleshooting missing blocks (with the help of compaction failure metric in 0.6.0)

I am running Thanos components behind a reverse proxy (traefik to be exact), and when reverse proxying the bucker web interface under /bucket it fails to load all static assets under /static.

This is most likely due to the ui not using relative paths.

As an example, I also run Thanos query under /query, and static assets are loaded under /query/static.

I work around by also reversing /static to the Thanos bucket web container but the configuration could be simpler.

      labels:
        - traefik.enable=true
        - traefik.port=8080
        - traefik.bucket.frontend.rule=Host:${HOSTNAME};PathPrefixStrip:/bucket
        - traefik.static.frontend.rule=Host:${HOSTNAME};PathPrefix:/static

There is no emergency in this but it would be nice to see it in the next iteration of bucket web

Thanks again for all the good work with Thanos !

@bwplotka

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

Yes! Definitely valid request, PRs welcome (:

@bwplotka

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

AC:

  • Enable relative path (or web.external-url) for thanos bucket web
@jdel

This comment has been minimized.

Copy link
Author

commented Jul 24, 2019

This is something I could look at but not in the next few days.

Do you have a roadmap for the next version ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.