New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Flaky test #1442
Comments
thanos/pkg/reloader/reloader_test.go Line 182 in c35d47b
Reason: plus op is not an atomic operation. |
@bwplotka @johncming I guess that the reloader read the middle status of watched files, because of using
Then trigger reload handler twice, the atomic would be added twice. |
@johncming I think this part is ok as there is only a single writer. @jojohappy you are right but this can happen normally as well so we should handle it properly. IMO it is just a CI slowdown, so increasing timeout here |
Quite often spotted.
The text was updated successfully, but these errors were encountered: