Block viewer: Show blocks marked for deletion

[roidelapluie]

Thanos, Prometheus and Golang version used:

Object Storage Provider:

s3

What happened:

I am looking at the blocks viewer and I see overlapping blocks

What you expected to happen:

Blocks marked for deletion marked in a special way

[kakkoyun]

@Shini31 Could this be the same issue as #3307?

[kakkoyun]

@prmsrswt Any input on this?

[onprem]

They are in different rows so they are not necessarily overlapping here. Each unique downsampling resolution - compaction level gets its own row.

Although we are currently not differentiating blocks which are marked for deletions but we have that in our roadmap and hopefully will be implemented during this community bridge period.

[roidelapluie]

What I mean is to find blocks that have a deletion-mark.json file.

[mcinquin]

@Shini31 Could this be the same issue as #3307?

Yes, there is.
This feature will be very helpful to determine if there is an overlap issue or not.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[mcinquin]

up?

[onprem]

Yeah this is on our roadmap, help wanted!

[mcinquin]

Good news!
I can help for the development, but i'm available for testing

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[anuraagbarde]

Hello there! I have experience with working in React, as this is marked as a good first issue how can I contribute? Thanks.

[onprem]

We can break this down in some steps:

1. Extend the blocks API endpoint to expose which blocks are marked for deletion.
   • In Thanos, blocks which are going to get deleted have a file named deletion-mark.json, we can use this information to return an additional boolean in the API response, markedForDeletion: true | false.
2. Use this information in the React UI to visually distinguish the blocks which are marked for deletion.

The first step will require some Go knowledge, as our backend is written in Go, the second step, however, is purely React work.

[anuraagbarde]

Ok, I will look into this, thanks for the info.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[mcinquin]

Up

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[mcinquin]

Up

[yeya24]

This is still nice to have.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[mcinquin]

Up

[keremgocen]

Hello, is anyone working on this? I'm looking for something to contribute.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Closing for now as promised, let us know if you need this to be reopened! 🤗

[keremgocen]

Up!