From d121fc9352a9cc57cc32aed3b086289d57f2779d Mon Sep 17 00:00:00 2001 From: Nikita Matveenko Date: Sat, 25 Jun 2022 18:33:33 +0200 Subject: [PATCH] fix docs typo in metric thanos_compact_halted Signed-off-by: Nikita Matveenko --- docs/components/compact.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/components/compact.md b/docs/components/compact.md index 337c38c1bc..19855961f8 100644 --- a/docs/components/compact.md +++ b/docs/components/compact.md @@ -190,7 +190,7 @@ This value has to be smaller than upload duration and [consistency delay](#consi ## Halting -Because of the very specific nature of Compactor which is writing to object storage, potentially deleting sensitive data, and downloading GBs of data, by default we halt Compactor on certain data failures. This means that that Compactor does not crash on halt errors, but instead is kept running and does nothing with metric `thanos_compactor_halted` set to 1. +Because of the very specific nature of Compactor which is writing to object storage, potentially deleting sensitive data, and downloading GBs of data, by default we halt Compactor on certain data failures. This means that that Compactor does not crash on halt errors, but instead is kept running and does nothing with metric `thanos_compact_halted` set to 1. Reason is that we don't want to retry compaction and all the computations if we know that, for example, there is already overlapped state in the object storage for some reason. @@ -243,7 +243,7 @@ The only risk is that without compactor running for longer time (weeks) you migh The main and only `Service Level Indicator` for Compactor is how fast it can cope with uploaded TSDB blocks to the bucket. -To understand that you can use mix `thanos_objstore_bucket_last_successful_upload_time` being quite fresh, `thanos_compactor_halted` being non 1 and `thanos_blocks_meta_synced{state="loaded"}` constantly increasing over days. +To understand that you can use mix `thanos_objstore_bucket_last_successful_upload_time` being quite fresh, `thanos_compact_halted` being non 1 and `thanos_blocks_meta_synced{state="loaded"}` constantly increasing over days. Example view of compactor not coping with amount and size of incoming blocks