Materials for Grafanacon 2019 #866
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
force-pushed
the
grafanacon-la-2019
branch
5 times, most recently
from
1103f1d to
7d0cdbb
Compare
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
grafanacon-la-2019
branch
from
7d0cdbb to
26bdd81
Compare
domgreen
approved these changes
Mar 27, 2019
Contributor
domgreen
left a comment
domgreen
left a comment
There was a problem hiding this comment.
LGTM - just nits but nothing blocking
| mountPath: /var/prometheus | ||
| - name: thanos | ||
| image: improbable/thanos:v0.3.1 | ||
| image: improbable/thanos:v0.3.2-rc.0 |
Contributor
There was a problem hiding this comment.
any way we can template this or get it from the VERSION file?
| # pipeline is functional. | ||
| # expr: vector(1) | ||
| # labels: | ||
| # severity: none |
Contributor
There was a problem hiding this comment.
delete rather than comment
Member
Author
|
Not actionable anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bartek Plotka bwplotka@gmail.com