Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Materials for Grafanacon 2019 #866

Closed
wants to merge 1 commit into from
Closed

Materials for Grafanacon 2019 #866

wants to merge 1 commit into from

Conversation

@bwplotka
Copy link
Member

@bwplotka bwplotka commented Feb 25, 2019

Signed-off-by: Bartek Plotka bwplotka@gmail.com

@bwplotka bwplotka force-pushed the grafanacon-la-2019 branch 5 times, most recently from 1103f1d to 7d0cdbb Feb 25, 2019
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Copy link
Contributor

@domgreen domgreen left a comment

LGTM - just nits but nothing blocking

@@ -115,7 +115,7 @@ spec:
- name: prometheus
mountPath: /var/prometheus
- name: thanos
image: improbable/thanos:v0.3.1
image: improbable/thanos:v0.3.2-rc.0
Copy link
Contributor

@domgreen domgreen Mar 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any way we can template this or get it from the VERSION file?

# pipeline is functional.
# expr: vector(1)
# labels:
# severity: none
Copy link
Contributor

@domgreen domgreen Mar 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete rather than comment

@bwplotka
Copy link
Member Author

@bwplotka bwplotka commented Oct 3, 2019

Not actionable anymore.

@bwplotka bwplotka closed this Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants