Enable installation as submodule

[CHE1RON]

Hey there,
this commit fixes #74, closely following the official sources on plugins supporting manual installation (ZIP folder, submodule, ..)

Cheers,
Martin

[thathoff]

Thank you for your pull request. The reason this has not been done yet is that we now include dependencies in the plugin and I’m not sure if I want to be responsible for keeping those dependencies up to date.

To better understand your setup: What is the reason you are using git submodules and don’t install directly via composer? That might be very handy to know and understand the need for supporting this. Thank you!

[CHE1RON]

Hey there @thathoff
I'm never ever using submodules in my projects, but I know people who do - furthermore, some devs and even non-tech folks like to download ZIP files, unpack them and give plugins a try first - again, not me, I'm a Composer guy - but nonetheless in my plugins I always include these dependencies.

Thing is: the few people going down the ZIP/submodule route never complained about dependencies, everyone else using Composer does not bother either way 😉

[thathoff]

Thank you. Nevertheless I will still be responsible for keeping the dependencies up to date. To support basic zip installation I’ve added this section to the readme. But yeah I totally understand your point. As this is a plugin for the more technically advanced people I thought it’s ok to just support the composer installation. But I might change my opinion on this ;)

[CHE1RON]

Right, thanks for your feedback! I saw the issue and just went from there actually 😅

[mlbiche]

Hi 👋 Is there any move expected/planned on this PR ?

[thathoff]

I’ve not made a decision if we should include the dependencies here. To get a better understanding on how the plugin is used: Can you explain how you run your setup that you need this and eg. cannot use composer or the way described in the readme?

Thank you!

[CHE1RON]

(On a side note: Every single one of my plugins using Composer includes its dependencies so people may simply download & test them ..)

[thathoff]

Yeah, but in our case we use composer requirements to also restrict the installation to working Kirby versions which results in a complete Kirby copy inside the vendor folder inside the repository which is also not a good idea.

I saw other plugins solving this by defining Kirby versions as dev dependency. Maybe that’s a way to go…

[thathoff]

Cherry picked into the 5.1.0 Release Branch so im closing this here. Thank you!

[CHE1RON]

Thanks for this plugin, happy to help anytime 😉