Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality profiles #26

Open
ohnodk opened this issue Sep 8, 2019 · 2 comments
Open

Quality profiles #26

ohnodk opened this issue Sep 8, 2019 · 2 comments

Comments

@ohnodk
Copy link

ohnodk commented Sep 8, 2019

Congrats on your new project. Looks promising.

Now to the point. Please don't copy the quality profiles from Radarr. They're so rigid and counter productive.

Problems:

  • Each rip type (HDTV, WEBDL, Bluray etc), is restricted to one bitrate range. But what if you want a high bitrate BDRip for your favorite movies and a low bitrate BDRip for the rest? Or what if you don't even care about the rip type and you just want high bitrate 1080p and low bitrate 1080p. AFAIK, that's not possible without setting a bitrate range for each type. But if you do that you're needlessly filtering the source of the rip, thus limiting yourself.
  • You can only have one profile per movie. Say you have a standard profile 1080p h264 for all your movies, but for your big 4k tv you'd also like a 2160p h265 copy of your favorite movies. Do you pick quantity or quality?

Instead allow for creation of custom movie profiles like the examples below:

quality_definitions //user defined but with healthy defaults

[
  {
    id: 0
    name: 'h265 high',
    codec: 'h265',
    allowed_resolutions: ['2160'],
    bitrate_min: 10,000,
    bitrate_max: 30,000
  },
  {
    id: 1,
    name: 'h265 low',
    codec: 'h265',
    allowed_resolutions: ['2160', '1080'],
    bitrate_min: 500,
    bitrate_max: 3,000
  },
  {
    id: 2,
    name: 'h264 low',
    codec: 'h264',
    allowed_resolutions: ['2160', '1080', '720'],
    bitrate_min: 1,000,
    bitrate_max: 3,000
  }
]

quality_profiles //user defined but with healthy default(s)

[
  {
    id: 0,
    name: 'Big screen movies',
    quality_profiles: [1] //h265 high
  },
  {
    id: 1,
    name: 'Default Profile',
    quality_profiles: [2, 3] //h265 low & h264 low
  },
  {
    id: 2,
    name: 'Compatibility profile',
    quality_profiles: [2] //the ipads and the kid's TV can't handle h265
  }
]

wanted_movies

[
  {
    name: 'Mad Max: Fury Road (2015)',
    imdb_id: 'tt1392190',
    wanted_qualities: [0, 1] //Big screen and default profile - we want it for the projector as well as for the bedroom TV
    ...
  },
  {
    name: 'Toy Story 4 (2019)',
    imdb_id: 'tt1979376',
    wanted_qualities: [0, 2] //Big screen and compatibility  profile - we want it for the projector as well as for the kids TV
    ...
  },
  {
    name: 'Gone Fishin (1997),
    imdb_id: 'tt0119214',
    wanted_qualities: [1] //Default profile - No need for high bitrate or compatibility for this one.
    ...
  }
@thcolin
Copy link
Owner

thcolin commented Sep 17, 2019

Hi ! Thanks for your interest in this project !

I'm working on new features, and I was thinking about a "multiple policies" feature. You'll have your default policy and you'll be able to create as many policies as you want and then decide for each movie which policies you're searching for this movie, like default and 4k for you.

For example, I was thinking of using it personnally to create a blockbuster policy that would filter language other than FRENCH|TRUEFRENCH|MULTI. Would that cover your needs ?

@JigSawFr
Copy link

JigSawFr commented Feb 2, 2020

Totally agree ! Thank you @thcolin for you hard work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants