From d5efb9cc1be799d16e5e73986e0e835473b5c837 Mon Sep 17 00:00:00 2001
From: Brian Schnee <77141303+brianschnee@users.noreply.github.com>
Date: Mon, 13 Jun 2022 23:03:42 -0400
Subject: [PATCH 1/4] Updated Comments
---
public/js/main.js | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/public/js/main.js b/public/js/main.js
index 0d97e33..ad07309 100644
--- a/public/js/main.js
+++ b/public/js/main.js
@@ -39,8 +39,9 @@ function renderMatches(matches) {
const list = document.getElementById('result-list');
list.innerHTML = '';
- // For every match found, render the objects to the DOM in JSON format
- if(matches.length > 0) {
+ // If matches exist, render each match to the DOM
+ if(matches.length) {
+ // For every match found, render the objects to the DOM in JSON format
matches.forEach(match => {
const li = document.createElement('li');
@@ -52,8 +53,9 @@ function renderMatches(matches) {
list.appendChild(li);
});
} else {
+ // Display "No matches were found" in result-list
in the DOM
const li = document.createElement('li');
li.innerText = 'No matches were found.';
list.appendChild(li);
}
-}
\ No newline at end of file
+}
From 2b5f30a1a916ce93bcaaefc191dc3d018328b7ca Mon Sep 17 00:00:00 2001
From: Brett Crafton <100751696+BrettCrafton@users.noreply.github.com>
Date: Mon, 13 Jun 2022 23:01:26 -0500
Subject: [PATCH 2/4] add res: SEO Guide to Lighthouse Performance Metrics
---
resources.js | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/resources.js b/resources.js
index 9ad725c..1c6b97a 100644
--- a/resources.js
+++ b/resources.js
@@ -285,6 +285,11 @@ const resources = [
url: 'https://htmlcheatsheet.com/seo/',
keywords: ['SEO', 'cheat sheet']
},
+ {
+ name: 'SEO Guide to Lighthouse Performance Metrics',
+ url: 'https://www.searchenginejournal.com/core-web-vitals/technical-seo-lighthouse/',
+ keywords: ['SEO', 'lighthouse', 'performance', 'metrics']
+ },
// Resource Format - please follow the styling below.
// {
// name: '',
From bd915f937ed344a50f53577267ee3b1f88686455 Mon Sep 17 00:00:00 2001
From: Brett Crafton <100751696+BrettCrafton@users.noreply.github.com>
Date: Tue, 14 Jun 2022 12:13:10 -0500
Subject: [PATCH 3/4] add res: centering in css
---
resources.js | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/resources.js b/resources.js
index 1c6b97a..035a82e 100644
--- a/resources.js
+++ b/resources.js
@@ -290,6 +290,11 @@ const resources = [
url: 'https://www.searchenginejournal.com/core-web-vitals/technical-seo-lighthouse/',
keywords: ['SEO', 'lighthouse', 'performance', 'metrics']
},
+ {
+ name: 'Centering in CSS',
+ url: 'https://ishadeed.com/article/learn-css-centering/#:~:text=To%20center%20an%20inline%20element,is%20text%2Dalign%3A%20center%20.&text=For%20multiple%20inline%20elements%2C%20the,using%20text%2Dalign%3A%20center%20',
+ keywords: ['CSS', 'center', 'align', 'guide]
+ },
// Resource Format - please follow the styling below.
// {
// name: '',
From d8dfc0595be55d8d7e6a78005c855d384958799b Mon Sep 17 00:00:00 2001
From: Brian Schnee <77141303+brianschnee@users.noreply.github.com>
Date: Tue, 14 Jun 2022 13:16:00 -0400
Subject: [PATCH 4/4] Update resources.js
Removed guide keyword, everything else looks perfect
---
resources.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/resources.js b/resources.js
index 035a82e..92852fe 100644
--- a/resources.js
+++ b/resources.js
@@ -293,7 +293,7 @@ const resources = [
{
name: 'Centering in CSS',
url: 'https://ishadeed.com/article/learn-css-centering/#:~:text=To%20center%20an%20inline%20element,is%20text%2Dalign%3A%20center%20.&text=For%20multiple%20inline%20elements%2C%20the,using%20text%2Dalign%3A%20center%20',
- keywords: ['CSS', 'center', 'align', 'guide]
+ keywords: ['CSS', 'center', 'align']
},
// Resource Format - please follow the styling below.
// {