New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opcache #445

Merged
merged 3 commits into from Oct 20, 2018

Conversation

Projects
None yet
2 participants
@1ma
Contributor

1ma commented Oct 19, 2018

Addresses #422. The configuration in use is the one found in the article I linked in the issue. It can be validated by accessing a running laravel, slim or symfony container and typing php-fpm -m and php-fpm -i | grep opca

In addition, Slim's nginx configuration has been tweaked to avoid an unnecessary disk access per request (the try_files directive), and the FastRoute cache has been enabled (in the end this is what has had the biggest impact on performance ¯\(ツ)/¯).

@waghanza

🎉 Thanks for your contribution

@waghanza

This comment has been minimized.

Collaborator

waghanza commented Oct 20, 2018

@1ma I've computed results from master and your PR, not sure how to understand results
For me docker usage is make results as garbage ;-)

I'll merge you PR and check again every implementation (with real results after cloudification -> hope at the end of this year)

Framework Average 50th percentile 90th percentile 99th percentile 99.9th percentile Standard deviation
master laravel (5.7) 219.98 ms 0.20 ms 595.75 ms 3018.78 ms 7066.39 ms 651246.33
master symfony (4.1) 204.90 ms 0.74 ms 676.82 ms 2947.31 ms 6984.36 ms 595785.67
master slim (3.11) 172.23 ms 0.98 ms 535.10 ms 2650.97 ms 7173.62 ms 507998.00
here laravel (5.7) 127.98 ms 0.95 ms 386.34 ms 1947.45 ms 5816.81 ms 388634.00
here symfony (4.1) 135.60 ms 1.67 ms 365.82 ms 2387.55 ms 7129.71 ms 458074.33
here slim (3.11) 126.33 ms 1.67 ms 342.31 ms 2234.87 ms 4938.26 ms 398147.67
@@ -5,8 +5,7 @@
require_once __DIR__ . '/../vendor/autoload.php';
$app = new App();
$app = new App(['settings' => ['routerCacheFile' => '/tmp']]);

This comment has been minimized.

@waghanza

waghanza Oct 20, 2018

Collaborator

I think this will break on IIS, no ?

This comment has been minimized.

@1ma

1ma Oct 20, 2018

Contributor

Yes, I always forget about Windows...This could be a call to sys_get_temp_dir() instead.

This comment has been minimized.

@waghanza

waghanza Oct 20, 2018

Collaborator

could made this in an other PR ?
I'm updating results

@waghanza waghanza merged commit dc6e607 into the-benchmarker:master Oct 20, 2018

1 check passed

codebeat no reportable quality changes
Details

@1ma 1ma deleted the 1ma:opcache branch Oct 20, 2018

waghanza added a commit that referenced this pull request Oct 20, 2018

Opcache (#445)
* php-opcache

* avoid extra access to disk on each request

* enable FastRoute cache
@waghanza

This comment has been minimized.

Collaborator

waghanza commented Oct 20, 2018

waghanza pushed a commit that referenced this pull request Oct 22, 2018

Opcache (#445)
* php-opcache

* avoid extra access to disk on each request

* enable FastRoute cache

waghanza pushed a commit that referenced this pull request Oct 22, 2018

Opcache (#445)
* php-opcache

* avoid extra access to disk on each request

* enable FastRoute cache

waghanza pushed a commit that referenced this pull request Oct 22, 2018

Opcache (#445)
* php-opcache

* avoid extra access to disk on each request

* enable FastRoute cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment