Fix geo intents on Android 11+ #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of querying for packages (which now requires <queries> entries in the manfiest, just catch ActivityNotFoundException
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Trying to tap on an event's location on Android 11+ currently results in a toast that says "No app can handle that request".
This is because Android 11 and above require applications that query other packages to declare what they want to query in the manifest with
<query>tags. See package visibility for more info on this change.The only reason we used this was to check if our links could be handled before launching them. Just launching the intent and catching any resulting
ActivityNotFoundExceptionhas the same effect, so that's the route I went to fix.Test Plan:
Tested current behavior on Android 12L, and it works now!
I also changed the
geo:intents to some garbage text to test the not found behavior, and confirmed the toast still displays as expected for unhandled intents.