Add SSL Notice to apidocs #1249

Open
phil-lopreiato opened this Issue Sep 13, 2015 · 10 comments

Projects

None yet

4 participants

@fangeugene
Member

Or not redirect /api/* to https

@gregmarra
Contributor

We should serve the API over HTTPS I think.

@phil-lopreiato want to comment on that thread we've filed an issue?

@phil-lopreiato
Member

I was just writing the reply post :)

@fangeugene
Member

@gregmarra Is there a good reason for serving the API over HTTPS? It's not like any of the data is sensitive, and it's possible some libraries don't support HTTPS.

We just got another email where we probably broke someone's app with HTTPS.

@gregmarra
Contributor

I feel we should keep everything HTTPS. It's better practice and everyone
will be able to figure it out pretty quickly. Let's add a banner alert to
the top of the apidocs
On Tue, Sep 15, 2015 at 15:49 Eugene Fang notifications@github.com wrote:

@gregmarra https://github.com/gregmarra Is there a good reason for
serving the API over HTTPS? It's not like any of the data is sensitive, and
it's possible some libraries don't support HTTPS.

We just got another email where we probably broke someone's app with HTTPS.


Reply to this email directly or view it on GitHub
#1249 (comment)
.

@phil-lopreiato
Member

Just got a report, Win XP + Chrome no likey SSL :(
https://code.google.com/p/chromium/issues/detail?id=451311

Banner for people to use FF instead?

@fangeugene
Member

No likey this particular version of SSL*

@gregmarra
Contributor

What do we need to do to make the SSL work for Chrome?

Can you open a separate issue to track this problem? This definitely needs
to be fixed.

On Thu, Sep 17, 2015 at 9:21 PM Phil Lopreiato notifications@github.com
wrote:

Just got a report, Win XP + Chrome no likey SSL :(
https://code.google.com/p/chromium/issues/detail?id=451311

Banner for people to use FF instead?


Reply to this email directly or view it on GitHub
#1249 (comment)
.

@fangeugene
Member
@bdaroz
Contributor
bdaroz commented Nov 13, 2016

Can probably close this with PR #1612, don't know what you'd want to do about #1250 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment