Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] admin > user list > view button #3998

Closed
ynizon opened this Issue Mar 11, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@ynizon
Copy link

ynizon commented Mar 11, 2019

Hello, i have found a bug.
When you click on view button from user list in admin, you have an error.
The bug is here:
https://github.com/the-control-group/voyager/blob/1.2/resources/views/bread/read.blade.php
Line 82 :
@if (!empty(json_decode($data->{$row->field})))
@foreach(json_decode($dataTypeContent->{$row->field}) as $item)
need to be:
@if (!empty(json_decode($dataTypeContent->{$row->field})))
@foreach(json_decode($dataTypeContent->{$row->field}) as $item)

Thanks to fix it

@ynizon ynizon added the possible bug label Mar 11, 2019

@emptynick

This comment has been minimized.

Copy link
Collaborator

emptynick commented Mar 11, 2019

From the issue-template.

The following information is required for bug reports. Issues without it will be closed without response

This can be reopened once the required informations are provided.

@emptynick emptynick closed this Mar 11, 2019

@ynizon

This comment has been minimized.

Copy link
Author

ynizon commented Mar 11, 2019

Version information

  • Laravel: v5.8
  • Voyager: v1.2.1
  • PHP: 7.2
  • Database: MySQL 8

Description

When you click on view button from user list in admin, you have an error in the template file.
data is undefined.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Go to 'admin > user list'
  2. Click on 'view button'
  3. See error

Expected behavior

You should see user description.

Additional context

I give you the fix. You just add it on your next release...

@ynizon

This comment has been minimized.

Copy link
Author

ynizon commented Mar 12, 2019

From the issue-template.

The following information is required for bug reports. Issues without it will be closed without response

This can be reopened once the required informations are provided.

i have added all details in my previous comment. Can you reopen ?

@emptynick emptynick reopened this Mar 12, 2019

@emptynick

This comment has been minimized.

Copy link
Collaborator

emptynick commented Mar 12, 2019

Fixed in 4ee291f

@emptynick emptynick closed this Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.