New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't load all relationship results #5465
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## 1.5 #5465 +/- ##
=========================================
Coverage 63.50% 63.50%
Complexity 1401 1401
=========================================
Files 195 195
Lines 4137 4137
=========================================
Hits 2627 2627
Misses 1510 1510 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfect
That's not really a lot information to reproduce. Edit: Seems like this happens when you have an ID field in the pivot table - is there a reason to have this? Edit 2: Fixed in 8c3c1dd |
Hello, @emptynick, thanks for the quick fix. Came here to give more info, but you already found it. That's exactly the scenario that causes the problem: I'm working on a project that have a pivot table with id column. |
* upstream/1.5: Hide download button if empty (thedevdojo#5487) Add Burmese Translations (thedevdojo#5488) Punctuation corrected (thedevdojo#5483) Update browse.blade.php (thedevdojo#5473) Automatic assets compilation (thedevdojo#5489) adding burmese lang (thedevdojo#5486) Fix belongs-to-many failing with ID on pivot table Bump path-parse from 1.0.6 to 1.0.7 (thedevdojo#5467) Bump tar from 6.1.0 to 6.1.11 (thedevdojo#5468) add ukrainian translations (thedevdojo#5448) Don't load all relationship results (thedevdojo#5465) Update Translatable.php (thedevdojo#5461)
In a belongs to many relationship all related items were loaded here:
https://github.com/the-control-group/voyager/blob/eb83ecb0f10192eed83dd8d2a3975dc3c8b32252/resources/views/formfields/relationship.blade.php#L174
Although we use ajax to load related items.
Another problem was that enabling tagging disabled ajax which does not make sense at all.
Possibilities tested: