[ET-1531] Tickets Commerce - SelectWoo Asset Missing When TEC is Deactivated #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bordoni
previously approved these changes
Jun 18, 2022
juanfra
previously approved these changes
Jun 20, 2022
juanfra
added
merge
…ing-when-tec-is-deactivated
juanfra
previously approved these changes
Jun 20, 2022
…ing-when-tec-is-deactivated
juanfra
previously approved these changes
Jun 20, 2022
…ing-when-tec-is-deactivated
juanfra
reviewed
Jun 21, 2022
…ing-when-tec-is-deactivated
Co-authored-by: Juan Aldasoro <juanfraa@gmail.com>
codingmusician
added
code review
…ing-when-tec-is-deactivated
redscar
approved these changes
Jun 21, 2022
juanfra
deleted the
fix/ET-1531-selectwoo-missing-when-tec-is-deactivated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
ET-1531
🗒️ Description
When TEC is deactivated and ET is used as a standalone plugin, we noticed that the dropdowns on the TC settings pages weren't using SelectWoo. We need to load these as dependencies in ET and not just TEC.
🎥 Artifacts
Before fix: https://www.screencast.com/t/DC507CcDRKO
After fix: https://www.screencast.com/t/8v2SOZFtGb
✔️ Checklist