merlin.el: Fix initial line to satisfy package.el #161

Merged
merged 1 commit into from Jan 11, 2014

Projects

None yet

3 participants

@purcell
Contributor
purcell commented Jan 10, 2014

A triple-semicolon is required in order for source files to be parseable by package-buffer-info, and therefore installed via package.el

Context: I'm adding merlin.el to MELPA

@purcell purcell merlin.el: Fix initial line to satisfy package.el
A triple-semicolon is required in order for source files to
be parseable by `package-buffer-info`, and therefore installed
via `package.el`
b69c5b2
@asmanur asmanur merged commit acdc51e into the-lambda-church:master Jan 11, 2014
@asmanur
Collaborator
asmanur commented Jan 11, 2014

Merged, thanks !

@trefis
Member
trefis commented Jan 11, 2014

Hi,
I want to react to:

Context: I'm adding merlin.el to MELPA

I am not sure that is a good idea. If you install "merlin-mode" from MELPA, you have no way to ensure that it will speak the same protocol as the "ocamlmerlin" binary. As the protocol still changes from times to times that is probably going to pose a problem one day or another.

That is the same reason why we discourage installing the vim plugin of merlin with Vundle.

@purcell
Contributor
purcell commented Jan 11, 2014

@trefis Thanks for expressing your concerns. This isn't the only split front-end/back-end tool in which concerns like this apply, but in practice incompatibility issues seem to be very rare. MELPA is explicitly a repo for cutting-edge packages, so users have opted in to a degree of potential breakage. I think it's enough for you to not directly encourage people to use the MELPA package. Relatedly, it's always nice if a front-end and back-end can verify that they are talking compatible protocols and raise appropriate errors.

@trefis
Member
trefis commented Jan 11, 2014

Relatedly, it's always nice if a front-end and back-end can verify that they are talking compatible protocols and raise appropriate errors.

That's a valid point.
I'll introduce such a check for the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment