Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django v2 compatibility #390

Merged
merged 9 commits into from Sep 2, 2018

Conversation

Projects
None yet
3 participants
@dadosch
Copy link
Contributor

dadosch commented Aug 24, 2018

No description provided.

@wmader

This comment has been minimized.

Copy link

wmader commented Aug 30, 2018

I tested the status as of this patch series. The webserver comes up, document consumption seems to work. While I get text extraction results presented via the web interface, I don't see thumbnails and can't download documents. How far is the django-2 port and what should work already? Is there some documentation what's to be done next, such that I could try to help?

@dadosch

This comment has been minimized.

Copy link
Contributor Author

dadosch commented Aug 30, 2018

@wmader you might want to have a look here: #386 but we started with combing out the obvious errors.

I just brought the server up again and I see thumbnails and can download documents just fine. Any error messages?

@wmader

This comment has been minimized.

Copy link

wmader commented Aug 31, 2018

@dadosch My issue is fixed with brookst@35ff657.

Thx for the pointer to the issue about porting.

@dadosch dadosch changed the title [WIP] django v2 compatibility django v2 compatibility Sep 1, 2018

@danielquinn

This comment has been minimized.

Copy link
Collaborator

danielquinn commented Sep 2, 2018

This is some amazing work guys. I've taken this branch, fixed the conflict in requirements.txt (sorry, that was me updating the dependencies earlier today) and then fixed an incompatibility in the API service. All appears to be going well, so I'm going to go ahead and merge this. Thank you so much to both of you for taking point on this!

@danielquinn danielquinn merged commit ec862ed into the-paperless-project:master Sep 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on django-v2 at 61.735%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.